-
Notifications
You must be signed in to change notification settings - Fork 0
Feat/music release tracker #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76772a2eb9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| try: | ||
| payload = fetch_search(artist, title) | ||
| found = is_exact_match(artist, title, payload) | ||
| except Exception: | ||
| found = False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fail fast on API errors instead of writing false negatives
The except Exception branch turns any HTTP/network/JSON error into found = False, so a transient 429/5xx or DNS issue will silently mark the track as missing and still produce a “successful” YAML file. That corrupts the output dictionary and makes the workflow pass with incorrect data. Consider surfacing the error (or at least failing the run) instead of treating failures as “not found.”
Useful? React with 👍 / 👎.
https://github.com/atls/infrastructure/issues/522