Skip to content

Conversation

@sanchitmehta94
Copy link
Contributor

@sanchitmehta94 sanchitmehta94 commented Jan 23, 2026

Removed flags from flutter analyze command.

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Two changes in PR

  1. Currently when we make a release we have to manually fix lint errors as those were not caught during PR runs. This changes ensure those errrors are caught during PR runs too. Flutter analyse should properly detect error in PR workflow too.
  2. Smoke tests have been failing for over two years. While we should plan to fix them, To avoid running checks in PRs that are guaranteed to fail unnecessarily, I have commented them for now with a TODO (so that it can be tracked and fixed later easily). Android ones were commented long back see here - > (
    # test-android-smoke:
    # name: Run native Android smoke tests using API-level ${{ matrix.android-api }}
    # runs-on: macos-latest-xl
    # environment: ${{ github.event.pull_request.head.repo.fork && 'external' || 'internal' }}
    # env:
    # USER_EMAIL: ${{ secrets.USER_EMAIL }}
    # USER_PASSWORD: ${{ secrets.USER_PASSWORD }}
    # ANDROID_EMULATOR_WAIT_TIME_BEFORE_KILL: 50
    # strategy:
    # matrix:
    # android-api:
    # - 32
    # steps:
    # - name: Checkout
    # uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3
    # - name: Gradle cache
    # uses: gradle/gradle-build-action@ef76a971e2fa3f867b617efd72f2fbd72cf6f8bc
    # - name: AVD cache
    # uses: actions/cache@v4
    # id: avd-cache
    # with:
    # path: |
    # ~/.android/avd/*
    # ~/.android/adb*
    # key: avd-${{ matrix.android-api }}
    # - name: Set up environment
    # uses: ./.github/actions/setup-android
    # with:
    # flutter: ${{ env.flutter }}
    # java: ${{ env.java }}
    # auth0-domain: ${{ vars.AUTH0_DOMAIN }}
    # auth0-client-id: ${{ vars.AUTH0_CLIENT_ID }}
    # - name: Build Android example app
    # working-directory: auth0_flutter/example
    # run: flutter build apk --split-per-abi
    ) . we ensure the CI stays all green from now 🟢✅.

Next steps: We would make all CI pipelines as mandatory check during PR runs currently these are optional checks by setting proper protection rules against main branch.

📎 References

🎯 Testing

Removed flags from flutter analyze command.
Comment out iOS smoke test configuration in workflow
@sanchitmehta94 sanchitmehta94 changed the title make PR runs with release workflow that triggers flutter analyze chore : CI improvements in flutter Jan 23, 2026
@sanchitmehta94 sanchitmehta94 changed the title chore : CI improvements in flutter chore : Improvements in PR pipelines Jan 23, 2026
Comment out macOS smoke tests and related environment setup.
- name: Analyze auth0_flutter_platform_interface package
working-directory: auth0_flutter_platform_interface
run: flutter analyze --no-fatal-warnings --no-fatal-infos
run: flutter analyze
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"prebump": "flutter analyze",

ship command uses the same command without flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants