-
Notifications
You must be signed in to change notification settings - Fork 33
fix: [DM-4] add Vale linting #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
mikemimik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 The output of the vale action is a little different than I expected. I thought that it would be similar to the terminal output you showed me @darrickyong when implementing this. My expectation was that the action would fail, not pass, and I'm curious why that is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✋🏽 Change Request: There are some duplications in this file for terms already in the CodeTerms/ folder. Can we use claude to validate there are no duplicates.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This PR updates the allowed list so that
vale .is error-free in theauth4genaifolder.References
Testing
Checklist