Skip to content

Conversation

@tstirrat15
Copy link
Collaborator

@tstirrat15 tstirrat15 commented Nov 25, 2025

Description

This is a part of getting this repo up-to-date. We want to get to next 16, react 19, and nextra 4, but doing all of those at once wasn't particularly fruitful. This starts by getting us from nextra 2->3.

TODO

  • Fix link checker issues

Changes

Will annotate.

Testing

Review. Look at the preview and see that:

  • highlighting in code blocks still looks as expected (including custom grammars)
  • buttons/cards/etc still look good
  • links etc still work as expected

@vercel
Copy link
Contributor

vercel bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Ready Ready Preview Comment Nov 26, 2025 2:58pm

Copy link
Collaborator Author

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@@ -1,6 +1,6 @@
---
name: "CLA"
on: # yamllint disable-line rule:truthy
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran Prettier over the repo. There are lots of autofix changes like this.

with:
config-file: ".yamllint"
- uses: "pnpm/action-setup@v3"
- uses: "pnpm/action-setup@v4"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplifying pnpm installation according to current instructions from the pnpm docs

Comment on lines +32 to +31
- name: "Check Formatting"
run: "pnpm run format:check"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a prettier check to enforce formatting

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettier

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured out that there isn't a reason for these to be in public, since they're only used at build time. I also ran prettier over them.

Comment on lines +35 to +36
"nextra": "^3",
"nextra-theme-docs": "^3",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the thrust of this PR.

"markdownlint-rule-max-one-sentence-per-line": "^0.0.2",
"postcss": "^8.4.39",
"shiki": "^0.14.7",
"shiki": "^1.29.2",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version used by v3 of Nextra.

Comment on lines +38 to +41
color: {
hue: { dark: 45, light: 290 },
saturation: { dark: 100, light: 100 },
},
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

primaryHue and primarySaturation became these.

banner: {
dismissible: false,
text: <Banner />,
content: <Banner />,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating per type

Comment on lines +24 to +33
<title>{resolvedTitle}</title>
<meta name="description" content={desc} />
<meta property="og:title" content={resolvedTitle} />
<meta property="og:description" content={desc} />
<link
rel="canonical"
href={`https://authzed.com${
process.env.NEXT_PUBLIC_BASE_DIR ?? ""
}${asPath}`}
/>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was one of the more meaningful changes - rather than having a separate hook/property for SEO stuff, nextra v3 just uses head tag stuff. Please check my work here.

@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from c83d074 to 708a8e6 Compare November 25, 2025 23:09
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from 708a8e6 to c4897f7 Compare November 26, 2025 13:31
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from c4897f7 to fa9b1ab Compare November 26, 2025 13:33
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from fa9b1ab to 47f8cea Compare November 26, 2025 13:35
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from 47f8cea to 1f8d1b0 Compare November 26, 2025 13:37
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from 1f8d1b0 to 5b5c951 Compare November 26, 2025 13:42
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from 5b5c951 to e88f75c Compare November 26, 2025 13:48
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from e88f75c to 460d198 Compare November 26, 2025 14:34
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch 2 times, most recently from a8125c0 to ea7dc05 Compare November 26, 2025 14:36
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from ea7dc05 to d6fdac4 Compare November 26, 2025 14:38
@tstirrat15 tstirrat15 force-pushed the nextra-incremental-upgrade branch from d6fdac4 to 677f72a Compare November 26, 2025 14:41
@tstirrat15
Copy link
Collaborator Author

The link checker complaints are because I got rid of a page that you can't actually access. It's still technically a "link" on the button on the sidebar, but that's wrong and I don't really want to keep a page around just for that reason.

@tstirrat15 tstirrat15 marked this pull request as ready for review November 26, 2025 15:05
Copy link
Contributor

@alecmerdler alecmerdler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@tstirrat15 tstirrat15 merged commit f18bbfb into main Nov 26, 2025
10 of 11 checks passed
@tstirrat15 tstirrat15 deleted the nextra-incremental-upgrade branch November 26, 2025 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants