-
Notifications
You must be signed in to change notification settings - Fork 46
Nextra incremental upgrade #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
bd7a2c6 to
da14306
Compare
da14306 to
c83d074
Compare
tstirrat15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| name: "CLA" | |||
| on: # yamllint disable-line rule:truthy | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran Prettier over the repo. There are lots of autofix changes like this.
| with: | ||
| config-file: ".yamllint" | ||
| - uses: "pnpm/action-setup@v3" | ||
| - uses: "pnpm/action-setup@v4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplifying pnpm installation according to current instructions from the pnpm docs
| - name: "Check Formatting" | ||
| run: "pnpm run format:check" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a prettier check to enforce formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prettier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured out that there isn't a reason for these to be in public, since they're only used at build time. I also ran prettier over them.
| "nextra": "^3", | ||
| "nextra-theme-docs": "^3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the thrust of this PR.
| "markdownlint-rule-max-one-sentence-per-line": "^0.0.2", | ||
| "postcss": "^8.4.39", | ||
| "shiki": "^0.14.7", | ||
| "shiki": "^1.29.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the version used by v3 of Nextra.
| color: { | ||
| hue: { dark: 45, light: 290 }, | ||
| saturation: { dark: 100, light: 100 }, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
primaryHue and primarySaturation became these.
| banner: { | ||
| dismissible: false, | ||
| text: <Banner />, | ||
| content: <Banner />, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating per type
| <title>{resolvedTitle}</title> | ||
| <meta name="description" content={desc} /> | ||
| <meta property="og:title" content={resolvedTitle} /> | ||
| <meta property="og:description" content={desc} /> | ||
| <link | ||
| rel="canonical" | ||
| href={`https://authzed.com${ | ||
| process.env.NEXT_PUBLIC_BASE_DIR ?? "" | ||
| }${asPath}`} | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was one of the more meaningful changes - rather than having a separate hook/property for SEO stuff, nextra v3 just uses head tag stuff. Please check my work here.
c83d074 to
708a8e6
Compare
708a8e6 to
c4897f7
Compare
c4897f7 to
fa9b1ab
Compare
fa9b1ab to
47f8cea
Compare
47f8cea to
1f8d1b0
Compare
1f8d1b0 to
5b5c951
Compare
5b5c951 to
e88f75c
Compare
e88f75c to
460d198
Compare
a8125c0 to
ea7dc05
Compare
ea7dc05 to
d6fdac4
Compare
d6fdac4 to
677f72a
Compare
677f72a to
be5615c
Compare
be5615c to
ab8e56f
Compare
ab8e56f to
8b7afc9
Compare
8b7afc9 to
6909512
Compare
6909512 to
5874cdd
Compare
|
The link checker complaints are because I got rid of a page that you can't actually access. It's still technically a "link" on the button on the sidebar, but that's wrong and I don't really want to keep a page around just for that reason. |
alecmerdler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
This is a part of getting this repo up-to-date. We want to get to next 16, react 19, and nextra 4, but doing all of those at once wasn't particularly fruitful. This starts by getting us from nextra 2->3.
TODO
Changes
Will annotate.
Testing
Review. Look at the preview and see that: