Skip to content

Fix ouvert issues #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
avaskys wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Fix ouvert issues #208

avaskys wants to merge 1 commit into from

Conversation

@avaskys
Copy link
Contributor

@avaskys avaskys commented Dec 29, 2025

  • In local games, player panel cards need to be refreshed to show post-discard hand. Previously the initial hand was incorrectly being shown.
  • For ISS games, post-game summaries may not include the ouvert cards. So don't fail validation if they are empty.

@avaskys
Fix ouvert issues
709fbfb 
- In local games, player panel cards need to be refreshed to show post-discard hand.
  Previously the initial hand was incorrectly being shown.
- For ISS games, post-game summaries may not include the ouvert cards. So don't
  fail validation if they are empty.
@avaskys avaskys marked this pull request as draft December 29, 2025 09:00
@avaskys
Copy link
Contributor Author

avaskys commented Dec 29, 2025

Oops missed the test failure, will re-assess the fix approach for the ISS issue

@b0n541
Copy link
Owner

b0n541 commented Dec 31, 2025

Thank you for taking care of this. I'll be on vacation for the next 2 weeks. So, take your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avaskys @b0n541