Skip to content

Reorder checks in toCode #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilikesymmetry merged 1 commit into from
Oct 1, 2025
Merged

Reorder checks in toCode #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/BuilderCodes.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ contract BuilderCodes is
/// @return tokenId The token ID for the referral code
function toTokenId(string memory code) public pure returns (uint256 tokenId) {
if (!isValidCode(code)) revert InvalidCode(code);
return uint256(LibString.toSmallString(code));
tokenId = uint256(LibString.toSmallString(code));
}

/// @notice Converts a token ID to a referral code
Expand All @@ -306,10 +306,10 @@ contract BuilderCodes is
///
/// @return code The referral code for the token ID
function toCode(uint256 tokenId) public pure returns (string memory code) {
code = LibString.fromSmallString(bytes32(tokenId));
if (bytes32(tokenId) != LibString.normalizeSmallString(bytes32(tokenId))) revert InvalidTokenId(tokenId);
bytes32 smallString = bytes32(tokenId);
if (smallString != LibString.normalizeSmallString(smallString)) revert InvalidTokenId(tokenId);
code = LibString.fromSmallString(smallString);
if (!isValidCode(code)) revert InvalidCode(code);
return code;
}

/// @notice Disabled to prevent accidental ownership renunciation
Expand Down