Submission freeze limit to elig users #964
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submission freeze restricted, eligibility changing rules changed. Updated IsEpisodeMutableForTeam permission Added more test cases for submission freezes Fixed test cases
lowtorola
force-pushed
the
submission_freeze_limit_to_elig_users
branch
from
ee529e8 to
5d045dc
Compare
lowtorola
approved these changes
Dec 31, 2025
Contributor
lowtorola
left a comment
lowtorola
left a comment
There was a problem hiding this comment.
LGTM! but let's wait to ship until after the season starts since this is not urgent and we have some big behemoths coming thru (crossplay anyone?)
| return True | ||
|
|
||
|
|
||
| class IsEpisodeMutable(permissions.BasePermission): |
Contributor
There was a problem hiding this comment.
did we want to remove this? or is it still in use
| self.assertFalse(m.matches.exists()) | ||
|
|
||
|
|
||
| class TeamEligibilityFreezeTestCase(TestCase): |
Contributor
There was a problem hiding this comment.
very cool! we looooove testing our code omg 😎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated submission freeze logic to only block submissions for teams that are currently eligible for an active tournament. Also blocks teams for changing their own eligibility criteria while any tournaments are active. Changed permissions, added tests for new behavior.
closes #916