Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Dec 30, 2025

Before this PR the error message would not be super helpful and may
potentially make it hard to debug and report errors. This PR does the
following:

  • Add a better error message which also adds comparison of the args with
    which we create the whl library.
  • Add a test that ensures that the error message is legible and works.
  • Add the necessary plumbing to logger to allow for testing error
    messages.

A proper fix requires more work, so just adding better logging and error
messages may be useful here.

Work towards #3479

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the PyPI module's error handling for duplicate whl_library definitions. The primary goal is to provide more actionable and detailed feedback to users when such conflicts occur, significantly improving the debuggability of build configurations. It achieves this by introducing a dictionary comparison utility and integrating it with an enhanced logging mechanism, ensuring that conflicting arguments are clearly presented in the error output.

Highlights

  • Improved Error Messaging: The error message for duplicate PyPI whl_library entries has been enhanced to provide detailed comparisons of the arguments that led to the conflict, making debugging easier.
  • Enhanced Logger Functionality: The internal logger utility (repo_utils.bzl) now supports custom printer functions and includes a failed() method to check if any fail messages were logged, which is crucial for testing error conditions.
  • New Test Case: A new test (_test_err_duplicate_repos) has been added to specifically verify the clarity and content of the improved error message when duplicate whl_library declarations with different arguments are encountered.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the error message for duplicate repository definitions, which will be very helpful for debugging. The changes to the logger to facilitate testing are well-designed. I've left one comment with suggestions to refine the new _diff_dict utility function by improving its documentation and removing an unused variable. Overall, this is a great enhancement.

Before this PR the error message would not be super helpful and may
potentially make it hard to debug and report errors. This PR does the
following:
* Add a better error message which also adds comparison of the args with
  which we create the whl library.
* Add a test that ensures that the error message is legible and works.
* Add the necessary plumbing to logger to allow for testing error
  messages.

A proper fix requires more work, so just adding better logging and error
messages may be useful here.

Work towards bazel-contrib#3479
@aignas aignas force-pushed the aignas.refactor.better-error-message-on-duplicate-repos branch from ea90dd7 to 411de7c Compare December 30, 2025 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant