-
-
Notifications
You must be signed in to change notification settings - Fork 645
refactor(pypi): print a better error message for duplicate repos #3487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor(pypi): print a better error message for duplicate repos #3487
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the PyPI module's error handling for duplicate Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves the error message for duplicate repository definitions, which will be very helpful for debugging. The changes to the logger to facilitate testing are well-designed. I've left one comment with suggestions to refine the new _diff_dict utility function by improving its documentation and removing an unused variable. Overall, this is a great enhancement.
Before this PR the error message would not be super helpful and may potentially make it hard to debug and report errors. This PR does the following: * Add a better error message which also adds comparison of the args with which we create the whl library. * Add a test that ensures that the error message is legible and works. * Add the necessary plumbing to logger to allow for testing error messages. A proper fix requires more work, so just adding better logging and error messages may be useful here. Work towards bazel-contrib#3479
ea90dd7 to
411de7c
Compare
Before this PR the error message would not be super helpful and may
potentially make it hard to debug and report errors. This PR does the
following:
which we create the whl library.
messages.
A proper fix requires more work, so just adding better logging and error
messages may be useful here.
Work towards #3479