Allow download outDir to be relative #638
Open
+141
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywmei-brt1
force-pushed
the
fix-download-base-path
branch
from
39e169e to
97e85a8
Compare
Our previous change is blocking outDir to be . during CAS download. Also there is a bug that getAbsPath() will not really return a abs path if base is relative path, like foo/bar (it will return a relative path based on foo/bar instead) It is not necessay for blocking outDir to be ., we should allow download to happen as long as the output files are not escaping from outDir. This CL reslove the base (outDir) to an absolute path then generate the full path for output files.
ywmei-brt1
force-pushed
the
fix-download-base-path
branch
from
97e85a8 to
38ad5ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our previous change is blocking outDir to be . during CAS download. Also there is a bug that getAbsPath() will not really return a abs path if base is relative path, like foo/bar (it will return a relative path based on foo/bar instead)
It is not necessary for blocking outDir to be ., we should allow download to happen as long as the output files are not escaping from outDir. This CL reslove the base (outDir) to an absolute path then generate the full path for output files.