Discogs: fixes for: 6177, 6068

[henry-oberholtzer]

Description

Fixes #6177, #6068.

I fixed the issue in #6177 by removing the derived class interface, and moving those fields back into function variables. They're a bit unwieldy still, but that's the algorithm it came with. There's a lot of room to continue to improve the clarity of the code in that section, but I think that'll require a deeper overhaul.

For #6068, I created the ArtistInfo and AlbumArtistInfo typed dictionaries, and was able to centralize the logic of building the artist info into build_artistinfo and build_albumartistinfo. Tests for these scenarios were created largely by expanding existing tests to incorporate the new fields.

I think I'll have to re-think the entire algorithm for 6030 to make it more flexible at parsing the issue for #6030, so I'll move that to a later PR in the interest of getting the flex attr fix in.

To Do

• Changelog. (Add an entry to docs/changelog.rst to the bottom of one of the lists near the top of the document.)
• Tests.

[codecov]

Codecov Report

❌ Patch coverage is 94.70199% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.00%. Comparing base (2bd77b9) to head (ec23eec).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
beetsplug/discogs.py	94.70%	6 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6179      +/-   ##
==========================================
+ Coverage   67.93%   68.00%   +0.06%     
==========================================
  Files         137      137              
  Lines       18677    18741      +64     
  Branches     3155     3162       +7     
==========================================
+ Hits        12688    12744      +56     
- Misses       5324     5332       +8     
  Partials      665      665              

Files with missing lines	Coverage Δ
beetsplug/discogs.py	74.18% <94.70%> (+3.40%)	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.