Skip to content

Conversation

@matthewvolk
Copy link
Contributor

What/Why?

Updates the GitHub Actions deploy workflow to pass channel-specific environment variables to Vercel deployments. Previously, the workflow only parsed the tag to determine the deployment domain. Now it also:

  • Determines the appropriate env_prefix based on package name (CORE, MAKESWIFT, or B2B_MAKESWIFT)
  • Passes BIGCOMMERCE_CHANNEL_ID and BIGCOMMERCE_STOREFRONT_TOKEN from channel-specific secrets
  • Conditionally passes MAKESWIFT_SITE_API_KEY for Makeswift-based deployments

This allows each deployment channel to use its own BigCommerce store configuration rather than relying on environment variables that may already be set in Vercel.

Also fixes a typo in the job name ({{ github.ref_name }}${{ github.ref_name }}).

Testing

This change affects the CI deploy workflow. To test:

  • Trigger a deployment by publishing a tag matching one of the supported patterns
  • Verify the deployment uses the correct environment variables for each channel

Migration

This change adds a new workflow file. No migration needed for developers with forks—this file can be accepted as-is or customized to match your own deployment secrets.

@matthewvolk matthewvolk requested a review from a team as a code owner January 22, 2026 22:34
@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2026

⚠️ No Changeset found

Latest commit: 2f07074

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
catalyst Ready Ready Preview, Comment Jan 23, 2026 6:35pm

Request Review

@matthewvolk matthewvolk force-pushed the CATALYST-1652-deploy-with-env-for-different-channels branch from 66ea87e to d314cf4 Compare January 22, 2026 22:45
replace eval with bash arrays, add timeouts, improve secret handling
@matthewvolk
Copy link
Contributor Author

matthewvolk commented Jan 23, 2026

Added the following vars/secrets:

  • vars.CORE_BIGCOMMERCE_CHANNEL_ID
  • vars.MAKESWIFT_BIGCOMMERCE_CHANNEL_ID
  • vars.B2B_MAKESWIFT_BIGCOMMERCE_CHANNEL_ID
  • secrets.CORE_BIGCOMMERCE_STOREFRONT_TOKEN
  • secrets.MAKESWIFT_BIGCOMMERCE_STOREFRONT_TOKEN
  • secrets.B2B_MAKESWIFT_BIGCOMMERCE_STOREFRONT_TOKEN
  • secrets.MAKESWIFT_SITE_API_KEY
  • secrets.B2B_MAKESWIFT_SITE_API_KEY
  • vars.B2B_API_HOST
  • secrets.B2B_BIGCOMMERCE_ACCESS_TOKEN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants