Skip to content

Conversation

@btgoodwin
Copy link
Contributor

Description

Ticket(s) Addressed:

Design Summary

As pointed out in #216, ubuntu-latest was struggling at one point, so we're pinning this to 22.04 as the suggested fix.

There have also been several dozen dependabot attempts at updating dependencies for the last year or so with every action build pipeline being broken beginning farther back than that. This PR attempts to bring all this up-to-date in a working state.

NOTE: Soon™️ this repository will likely be archived/removed because our organization's use of it has moved to a different workflow of building GStreamer with our own plugins via Cerbero and then ingesting those build artifacts into our other application pipeline(s).

Configuration changes:

None

Testing Notes and Procedure

None

Related Pull Requests

None

@btgoodwin btgoodwin force-pushed the fix-216-ubuntu-22-04-vs-latest branch 7 times, most recently from 9361a06 to 1e253b5 Compare December 11, 2025 14:56
@btgoodwin btgoodwin force-pushed the fix-216-ubuntu-22-04-vs-latest branch 2 times, most recently from e1ea227 to f3e6822 Compare December 11, 2025 17:05
Fixes #216

Addresses the breakage from however long ago that prevented the
index.test.js -> index.js from actually printing useful messages when
the test fails, which indicated a change in how GHA core.getInput
behaves when you try to set a test input var to null.  This was causing
the index.js under test to run the direct MSI file download logic rather
than pulling from the expected URL.

Also pulls in the myriad of version bumps that happened over the last
two years for dependent packages, changes to eslint, etc.
@btgoodwin btgoodwin force-pushed the fix-216-ubuntu-22-04-vs-latest branch from f3e6822 to 77671a2 Compare December 11, 2025 17:09
@btgoodwin btgoodwin force-pushed the fix-216-ubuntu-22-04-vs-latest branch from 8bb5944 to 1d61bdf Compare December 11, 2025 18:24
@btgoodwin
Copy link
Contributor Author

btgoodwin commented Dec 11, 2025

If anyone wants to continue looking into this, what I've noticed so far is:

  1. Downloads/fetches are very flakey where we have to re-run jobs manually a few times in order to re-attempt downloads.
  2. The Ubuntu build using Cerbero fails in different spots, sometimes fetch-package, sometimes package. It's again something similar, where downloads will fail requiring you to re-run the job just to re-attempt the download until it succeeds, and then the whole process continues much farther.

In both cases, there isn't much we can do other than make every job have a retry count.

I've run out of bandwidth to dedicate to the ubuntu side of this. If someone wants to carry this forward, I recommend pulling an ubuntu-22.04 docker image, run apt update and then install npm, nodejs, and git. After that you should be able to clone this branch and run:

npm install
export INPUT_VERSION=1.26.8
node index.js

With any luck you'll be able to start debugging the next parts of index.js that need to be updated to support Ubuntu again. The steps that are included there right now roughly match those in the ci folder of cerbero.

Before submitting a patch though, you will need to run npm run prepare to update and git commit dist with your other changes so that the action can pass the dist test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants