composefs: Fix is_image_pulled check #1906
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream composefs-oci now writes manifest stream as oci-config-sha256:<sha256 checksum> Signed-off-by: Chaser Huang <huangkangjing@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where bootc upgrade would always attempt an upgrade due to an incorrect check for a pulled image. The fix correctly formats the manifest stream identifier to align with an upstream change in composefs-oci. The change is correct and necessary. I've added one suggestion to improve maintainability by defining a magic string as a constant.
Collaborator
|
The failure comes from grub2 regression. #1905 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 49d753f, upstream composefs-oci now writes manifest stream identifier as oci-config-sha256:. (ref)
This was not updated in commit mentioned above, causing bootc always attempting to upgrade when
bootc upgradeis ran, which will fail later at state writing stage due to already existing state directory.