Skip to content

Conversation

@Miniontoby
Copy link
Contributor

@Miniontoby Miniontoby commented Apr 11, 2025

Updated connectable.ts to work again for 1.21

Will require people to add the scripts/connectable.js to their main.js file in order to work!
I don't know how to make that super clear to them


And updated BlockRotationV2 to work in 1.21
This one doesn't require scripting.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Miniontoby Miniontoby changed the title Updated connectable.ts to work again for 1.21 Updated Connectable and BlockRotateV2 to 1.21 Apr 11, 2025
@outercloudstudio
Copy link
Member

Thank you for your contribution. I'll verify and hopefully merge it this weekend.

@Miniontoby
Copy link
Contributor Author

At least to show that it works on my end, here's a screenshot:

image

The blue lines have the Connectable and the RTC thing has the BlockRotateV2 (of course only one of the tags, but they are all updated, so go test them out, I don't know how I would test such thing)

@outercloudstudio
Copy link
Member

I was thinking about how to communicate to the user that main needs to be used. I think the best we can do is include the information in the plugin readme, then if a user is specifically confused and asks in the discord we point them to the answer.

@outercloudstudio outercloudstudio merged commit 60b917e into bridge-core:master Apr 13, 2025
1 check passed
@Miniontoby
Copy link
Contributor Author

Sounds good, not too sure if the readme is correct since you would just have your main in the scripts folder anyways

and then just add import './connectable.js' is good enough, but its fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants