Skip to content

Conversation

@pearmini
Copy link
Member

@pearmini pearmini commented Jun 8, 2025

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jun 8, 2025

Deploying charming with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1b0cd2
Status: ✅  Deploy successful!
Preview URL: https://1e85f727.charming-a13.pages.dev
Branch Preview URL: https://charming-dom.charming-a13.pages.dev

View logs

@pearmini pearmini force-pushed the charming-dom branch 4 times, most recently from 91a4fbb to b77eac2 Compare June 11, 2025 00:26
@pearmini pearmini force-pushed the charming-dom branch 2 times, most recently from fca3e28 to 6d63ba3 Compare June 12, 2025 23:16
@pearmini pearmini requested a review from Copilot June 12, 2025 23:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the previous rendering system with a new "charming-dom" implementation. The key changes are:

  • Removal of legacy test/app and rendering files (state.js, mark.js, renderer.js, etc.)
  • Addition of a new DOM module (src/dom.js) with updated API exports in src/index.js
  • Updates to package.json and test configurations to support the new system

Reviewed Changes

Copilot reviewed 59 out of 59 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/index.html Removed legacy test HTML interface.
test/dom.spec.js Added new tests validating event handling and datum passing.
test/apps/* Removed outdated app examples.
src/state.js Removed legacy state management implementation.
src/set.js Removed legacy attribute setting logic.
src/renderer.js Removed legacy renderer implementation.
src/math.js Removed legacy math utility.
src/mark.js Removed legacy mark-based rendering implementation.
src/index.js Updated exports to use the new dom-based API.
src/dom.js Introduces the new "charming-dom" implementation.
package.json Updated dependencies and scripts to support the new system.
.prettierignore Added new ignore rules for build output.
Comments suppressed due to low confidence (2)

src/dom.js:24

  • [nitpick] The function name 'set' is very generic and could potentially conflict with other utilities. Consider renaming it to a more descriptive name such as 'setDomAttribute' to enhance clarity.
function set(dom, k, v) {

src/index.js:1

  • [nitpick] The API export changes replace the legacy rendering functions with the new 'charming-dom' module. Consider adding documentation or an upgrade guide to clarify this change to API consumers.
export {svg, html, tag, render, renderMark} from "./dom.js";

@pearmini pearmini merged commit f511c87 into next Jun 14, 2025
2 checks passed
@pearmini pearmini deleted the charming-dom branch June 14, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants