Specialize payload of Wishbone to be BitVector (w * 8).
#184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmbollen
force-pushed
the
specialize-wishbone
branch
from
3b94d28 to
589ddca
Compare
Member
martijnbastiaan
left a comment
martijnbastiaan
left a comment
There was a problem hiding this comment.
After having used it in bittide for a year I'm very much in favor of this. Having to deal with divRu and its error messages isn't fun at all. From our conversations in the office I think I remember that most people were in favor too -- though I might be biased.
This was referenced Dec 18, 2025
lmbollen
force-pushed
the
specialize-wishbone
branch
2 times, most recently
from
28e59f4 to
f8ffcb3
Compare
martijnbastiaan
approved these changes
Jan 6, 2026
Member
martijnbastiaan
left a comment
martijnbastiaan
left a comment
There was a problem hiding this comment.
Could you remove cancelMulDiv?
The polymorphic nature was problematic because it required `DivRU` to determine the `selWidth`. In reality we don't expect to need this type of polymorphism for an addressable bus type and there is no basis for in the specification.
lmbollen
force-pushed
the
specialize-wishbone
branch
from
f8ffcb3 to
84bca4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polymorphic nature was problematic because it required
DivRUto determine theselWidth.In reality we don't expect to need this type of polymorphism for an addressable bus type and there is no basis for in the specification.
After merging this PR we should update at least:
clash-protocolsand adjust for newWishbonedefinition bittide/bittide-hardware#1136