sql/export: skip columns with Bit(0) type in parquet test #160093
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
Contributor
Author
|
Two random seeds that were helpful in verifying this off of master: |
aerfrei
requested review from
KeithCh and
log-head
and removed request for
a team and
log-head
KeithCh
approved these changes
Dec 24, 2025
KeithCh
reviewed
Dec 24, 2025
We were seeing failures on this randomized test when these columns were generated. The testutils parquet decoder can't handle this type (added in cockroachdb#132944) so these fail, but it doesn't represent a real issue. This fix skips these the randomly generated test cases that include this column type. Fixes: cockroachdb#154011 Epic: none Release note: None
aerfrei
force-pushed
the
issue-154011-bit-0
branch
from
65cea5b to
5c8981c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing failures on this randomized test when these columns were generated. The testutils parquet decoder can't handle this type (added in #132944) so these fail, but it doesn't represent a real issue.
This fix skips these the randomly generated test cases that include this column type.
Fixes: #154011
Epic: none
Release note: None