release-26.1: kvserverbase: allow MMA cluster setting in production builds #160118
+0
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `kv.allocator.load_based_rebalancing` cluster setting could only be set to "multi-metric only" or "multi-metric and count" in test builds or when the `COCKROACH_ALLOW_MMA` environment variable was set. Remove this restriction to allow MMA (multi-metric allocation) to be enabled in production. Also remove references to the now-unnecessary `COCKROACH_ALLOW_MMA` env var from roachtests and drtprod configs. Fixes: cockroachdb#159587 Epic: CRDB-55052
tbg
force-pushed
the
blathers/backport-release-26.1-159881
branch
from
1b3cf49 to
71a467a
Compare
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
requested review from
angeladietz,
arulajmani,
nameisbhaskar and
shailendra-patel
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
blathers-crl
bot
added
backport
Member
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #159881 on behalf of @tbg.
Previously, the
kv.allocator.load_based_rebalancingcluster setting could only be set to "multi-metric only" or "multi-metric and count" in test builds or when theCOCKROACH_ALLOW_MMAenvironment variable was set.Remove this restriction to allow MMA (multi-metric allocation) to be enabled in production. This is not recommended yet. Also remove references to the now-unnecessary
COCKROACH_ALLOW_MMAenv var from roachtests and drtprod configs.Fixes: #159587
Epic: CRDB-55052
Release justification: