catalog/lease: fix historical reads with locked leasing #160119
Draft
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This change is |
Previously, our last resort logic to read descriptors at the end timestamp for historical descriptors would behave incorrectly for locked descriptor leasing. This would read at the leased timestamp and, for initially created descriptors, incorrectly return "descriptor not found". Even if the descriptor is avaialble at the actual timestamp for the transaction. To address this, this patch surfaces these errors only if the base timestamp is not able to satisfy the request either. The findForTimestamp logic already attempts the base timestamp if the locked timestamp is not viable. Fixes: cockroachdb#159998 Release note: None
fqazi
force-pushed
the
handleHistoricReadsAtBase
branch
from
6e9224c to
7face00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, our last resort logic to read descriptors at the end timestamp for historical descriptors would behave incorrectly for locked descriptor leasing. This would read at the leased timestamp and, for initially created descriptors, incorrectly return "descriptor not found". Even if the descriptor is avaialble at the actual timestamp for the transaction. To address this, this patch surfaces these errors only if the base timestamp is not able to satisfy the request either. The findForTimestamp logic already attempts the base timestamp if the locked timestamp is not viable.
Fixes: #159998
Release note: None