sql/inspect: add per-span protected timestamp for "now" AOST case #160138
+183
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, INSPECT jobs without a historical AS OF SYSTEM TIME clause would not create protected timestamp records, but still used an AOST clause with the current timestamp. If span processing took a long time (especially with BulkLowQoS admission control), garbage collection could occur before the query completed, resulting in "batch timestamp must be after replica GC threshold" errors. This change adds per-span protected timestamp protection when INSPECT uses "now" as the AOST. It uses TryToProtectBeforeGC which waits until 80% of the GC TTL has elapsed before creating a PTS, avoiding unnecessary PTS creation for quick operations. The PTS is cleaned up when span processing completes. Resolves: cockroachdb#159866 Epic: None Release note: None
Member
|
This change is |
fqazi
approved these changes
Dec 24, 2025
Collaborator
fqazi
left a comment
fqazi
left a comment
There was a problem hiding this comment.
@fqazi reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @spilchen).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, INSPECT jobs without a historical AS OF SYSTEM TIME clause would not create protected timestamp records, but still used an AOST clause with the current timestamp. If span processing took a long time (especially with BulkLowQoS admission control), garbage collection could occur before the query completed, resulting in "batch timestamp must be after replica GC threshold" errors.
This change adds per-span protected timestamp protection when INSPECT uses "now" as the AOST. It uses TryToProtectBeforeGC which waits until 80% of the GC TTL has elapsed before creating a PTS, avoiding unnecessary PTS creation for quick operations. The PTS is cleaned up when span processing completes.
Resolves: #159866
Epic: None
Release note: None