Upgrade Pagy #2423
Open
Upgrade Pagy #2423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnclmorais
force-pushed
the
upgrade-pagy
branch
9 times, most recently
from
652201f to
2ee1552
Compare
| .col-auto | ||
| %p.mb-3 | ||
| != pagy_info(pagy, item_name: model.pluralize(pagy.count)) | ||
| != @pagy.info_tag(item_name: model.pluralize(@pagy.count)) |
Collaborator
There was a problem hiding this comment.
Maintenance note: we can pass in a local variable named pagy to this and other partials. That prepares us for Strict Locals in the future.
A nil/missin6 instance variable gives no meaningful error, whereas a missing local variable gives NameError - very clear and actionable.
Contributor
Author
There was a problem hiding this comment.
Seems like we’re already doing that, actually:
7 results - 4 files
app/views/admin/feedback/index.html.haml:
2 - if @feedback.any?
3: = render partial: 'shared/pagination', locals: { pagy: @pagy, model: 'feedback' }
4
26
27: = render partial: 'shared/pagination', locals: { pagy: @pagy, model: 'feedback' }
28
app/views/admin/members/events.html.haml:
17 %h3 Past RSVPs
18: = render partial: 'shared/pagination', locals: { pagy: @pagy, model: 'events' }
19
22
23: = render partial: 'shared/pagination', locals: { pagy: @pagy, model: 'events' }
app/views/admin/sponsors/index.html.haml:
15
16: = render partial: 'shared/pagination', locals: { pagy: @pagy, model: 'sponsor' }
17
43
44: = render partial: 'shared/pagination', locals: { pagy: @pagy, model: 'sponsor' }
app/views/coach/_coach.html.haml:
16
17: = render partial: 'shared/pagination', locals: { pagy: @pagy, model: 'coach' }
config/initializers/pagy.rb
Outdated
| # Pagy initializer file (6.2.0) | ||
| # Customize only what you really need and notice that the core Pagy works also without any of the following lines. | ||
| # Should you just cherry pick part of this file, please maintain the require-order of the extras | ||
| # Pagy initializer file (43.2.2) - UPGRADED from 6.2.0 |
Collaborator
There was a problem hiding this comment.
Ditch the history, it's super without it.
Collaborator
olleolleolle
left a comment
olleolleolle
left a comment
There was a problem hiding this comment.
Looks super! I only read the code changes, didn't look at the site in preview.
Seems like we are using it in select places only.
The new config experience is lovely.
Contributor
Author
|
I’ll update the rest either today or tomorrow — thanks @olleolleolle! |
Suggestion was “we can pass in a local variable named pagy to this and other partials. That prepares us for Strict Locals in the future.”
gnclmorais
force-pushed
the
upgrade-pagy
branch
from
2ee1552 to
57e4b6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Pagy gem, following this upgrade guide: https://ddnexus.github.io/pagy/guides/upgrade-guide 🐸