Use with function to wrap imagePullSecrets in serviceaccount.yaml #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an operator to inject _imagePullSecrets_ into deployed Kubernetes resources, instead of configuring them with values and running a `helm upgrade ...` later on, a conflict arises. The chart produces `imagePullSecrets: []` when none are set. To avoid this, simply wrap in a `with` clause like it is already done in deployment.yaml and statefulset.yaml. Signed-off-by: Sascha Peilicke <sascha@peilicke.de>
saschpe
force-pushed
the
saschpe.sa-imgpullsec
branch
from
06678e3 to
13dce0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an operator to inject imagePullSecrets into deployed Kubernetes resources, instead of configuring them with values and running a
helm upgrade ...later on, a conflict arises.The chart produces
imagePullSecrets: []when none are set. To avoid this, simply wrap in awithclause like it is already done in deployment.yaml and statefulset.yaml.