-
Notifications
You must be signed in to change notification settings - Fork 10
Add test analytics breadcrumbs #587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #587 +/- ##
==========================================
+ Coverage 93.85% 93.88% +0.02%
==========================================
Files 1284 1284
Lines 46453 46531 +78
Branches 1522 1526 +4
==========================================
+ Hits 43600 43685 +85
+ Misses 2543 2536 -7
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #587 will not alter performanceComparing Summary
Footnotes |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| **kwargs, | ||
| ) | ||
|
|
||
| # Log breadcrumb for upload complete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel these comments are a bit redundant since the milestone says that. Also seeing inconsistencies w/ some calls having comments and others not. Thoughts on removing altogether? Applies to all files
|
|
||
| @pytest.mark.django_db | ||
| def test_lock_retry_breadcrumbs_logged(self, mocker, dbsession, mock_self_app): | ||
| """Test that INTERNAL_LOCK_ERROR and INTERNAL_RETRYING breadcrumbs are logged on LockRetry.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for these and other comments.
If you think some are important/relevant that the code wouldn't otherwise explain, I'm okay with leaving
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.