Skip to content

Conversation

@maxweng-sentry
Copy link
Contributor

  • Adds breadcrumbs for test analytics processor and notifier tasks
  • Adds report type to coverage to distinguish between coverage vs test result uploads.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@sentry
Copy link

sentry bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.88%. Comparing base (c8018ba) to head (2f7ddf1).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #587      +/-   ##
==========================================
+ Coverage   93.85%   93.88%   +0.02%     
==========================================
  Files        1284     1284              
  Lines       46453    46531      +78     
  Branches     1522     1526       +4     
==========================================
+ Hits        43600    43685      +85     
+ Misses       2543     2536       -7     
  Partials      310      310              
Flag Coverage Δ
apiunit 96.55% <ø> (+<0.01%) ⬆️
sharedintegration 38.77% <43.47%> (+0.01%) ⬆️
sharedunit 88.78% <100.00%> (+0.01%) ⬆️
workerintegration 58.65% <57.14%> (+0.03%) ⬆️
workerunit 91.26% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-eu
Copy link

codecov-eu bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 26, 2025

CodSpeed Performance Report

Merging #587 will not alter performance

Comparing max/test-analytics-breadcrumbs (2f7ddf1) with main (39fb6a9)1

Summary

✅ 9 untouched

Footnotes

  1. No successful run was found on main (b081221) during the generation of this report, so 39fb6a9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

**kwargs,
)

# Log breadcrumb for upload complete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel these comments are a bit redundant since the milestone says that. Also seeing inconsistencies w/ some calls having comments and others not. Thoughts on removing altogether? Applies to all files


@pytest.mark.django_db
def test_lock_retry_breadcrumbs_logged(self, mocker, dbsession, mock_self_app):
"""Test that INTERNAL_LOCK_ERROR and INTERNAL_RETRYING breadcrumbs are logged on LockRetry."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for these and other comments.

If you think some are important/relevant that the code wouldn't otherwise explain, I'm okay with leaving

@codecov-test
Copy link

codecov-test commented Nov 30, 2025

Codecov Report

❌ Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
apps/worker/tasks/test_results_finisher.py 22.22% 7 Missing ⚠️
apps/worker/tasks/test_results_processor.py 90.90% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants