Skip to content

Conversation

@sazary
Copy link
Contributor

@sazary sazary commented Dec 13, 2025

resolves #101

this adds handleDeviceAttributes to the wasm patch, and it's implementation is a copy of deviceAttributes function in the main ghostty repo.

for reference, xterm.js returns different values than this but i thought it's better to use ghostty values.

i can confirm that this resolves the fish issue mentioned in the linked issue

@sazary sazary changed the title fix: Respond to the device attributes sequences (#101) fix: Respond to the device attributes sequences Dec 13, 2025
@eexwhyzee
Copy link
Contributor

+1 on this, ghostty-web not responding to device attributes queries is also causing nushell to take 2 seconds to start up too:
Screenshot 2025-12-13 at 10 06 17 PM

i applied the WASM patch in this PR on my local build and can confirm that the issue is resolved and nushell starts up appropiately:
Screenshot 2025-12-13 at 10 05 01 PM

@sreya
Copy link
Contributor

sreya commented Dec 14, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sreya
Copy link
Contributor

sreya commented Dec 15, 2025

Thanks for the contribution ❤️

@sreya sreya merged commit 2ede417 into coder:main Dec 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Should respond to device attributes sequences (da1/da2)

4 participants