Skip to content

Conversation

@eexwhyzee
Copy link
Contributor

this fix addresses a hanging issue when terminal integrations that buffer incoming data during async initialization (for example: https://github.com/jupyterlab/jupyterlab/blob/main/packages/terminal/src/widget.ts#L75-L115) can trigger multiple terminal query responses in a single write call.

things like neovim/nushell that send multiple queries and block waiting for responses, which hangs because currently only the first response was being sent back.

for example, trying to run neovim in jupyterlab would hang after the first response:
Screenshot 2025-12-13 at 2 12 58 PM

after the fix, neovim starts up successfully in jupyterlab:
Screenshot 2025-12-13 at 2 11 19 PM

@sreya
Copy link
Contributor

sreya commented Dec 14, 2025

Awesome thanks for this

@sreya
Copy link
Contributor

sreya commented Dec 14, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sreya sreya merged commit c7e37fb into coder:main Dec 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants