fix: Asset Whitelisting script #6008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathmeshkhandelwal1
requested review from
LayneHaber,
liu-zhipeng and
preethamr
as code owners
prathmeshkhandelwal1
changed the title
just-a-node
previously approved these changes
Apr 10, 2024
Collaborator
|
Assuming this has been tested on both psuedo-domain assets and regular assets? At least in dry run mode. |
Collaborator
Author
Yes, Also tested for deploy new local assets in case of new registeration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed asset whitelisting script to include xERC20 whitelisting. I.e Including pseudo canonical domain.
There is another PR for similar fix which resolves it by removing home canonical domain logic
#5935
The issue with above PR is that it is only relevant for xERC20s and bypasses some of the important checks for non-xERC20 asset.
Rather than removing canonical domain logic, This PR include creating a dummy network in init script for pseudo domains and bypass
updateIfNeededin case of domain:11111