feat(DocumentUploadQueue): add configurable batch size infrastructure #188
+108
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 29, 2026
- Add constants: MAX_ALLOWED_QUEUE_SIZE (256MB), DEFAULT_QUEUE_SIZE (256MB) - Add BATCH_SIZE_PROPERTY system property for runtime configuration - Add getConfiguredBatchSize() static method for system property lookup - Add new constructor with maxQueueSize parameter - Add validation to prevent exceeding 256MB API limit - Update existing constructor to use getConfiguredBatchSize() as default Configuration priority: constructor param > system property > default (256MB)
y-lakhdar
force-pushed
the
feat/configurable-batch-size-infrastructure
branch
from
3230e50 to
380eb01
Compare
y-lakhdar
changed the base branch from
main
to
fix/platform-client-null-userAgents
…o/push-api-client.java into feat/configurable-batch-size-infrastructure
lavoiesl
previously approved these changes
Jan 29, 2026
y-lakhdar
changed the base branch from
fix/platform-client-null-userAgents
to
main
lavoiesl
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds infrastructure for configurable batch sizing in DocumentUploadQueue. This is foundational work that enables services to configure their batch size.
Changes
MAX_ALLOWED_QUEUE_SIZE(256MB),DEFAULT_QUEUE_SIZE(256MB),BATCH_SIZE_PROPERTYgetConfiguredBatchSize()static method for system property configurationmaxQueueSizeparametergetConfiguredBatchSize()as defaultConfiguration
-Dcoveo.push.batchSize=<bytes>new DocumentUploadQueue(uploader, maxQueueSize)Testing
Part 2 of 3 - Split from PR #186
Dependencies: Should merge after #187