Fix bug with gitExec #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

apeace wants to merge 1 commit into creationix:master from apeace:master

apeace commented Oct 21, 2012

I ran into a problem with this line here: https://github.com/creationix/node-git/blob/master/lib/git-fs.js#L139

It was throwing an error because gitExec requires all three arguments. I've fixed that by defaulting to "utf8" if no encoding is given

Maybe it's simpler just to add the "utf8" parameter to the getExec call I linked above, that's up to you. I figured I would share this fix anyway


          Make encoding optional for gitExec

ce3ab73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet