Skip to content

Fix acts_as_tool_call message: option (#514) #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabh-sikchi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix acts_as_tool_call message: option (#514) #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/ruby_llm/active_record/chat_methods.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,8 +218,8 @@ def cleanup_orphaned_tool_results # rubocop:disable Metrics/PerceivedComplexity
if last.tool_call?
last.destroy
elsif last.tool_result?
tool_call_message = last.parent_tool_call.message
expected_results = tool_call_message.tool_calls.pluck(:id)
tool_call_message = last.parent_tool_call.message_association
expected_results = tool_call_message.tool_calls_association.pluck(:id)
actual_results = tool_call_message.tool_results.pluck(:tool_call_id)

if expected_results.sort != actual_results.sort
Expand Down
28 changes: 28 additions & 0 deletions spec/ruby_llm/active_record/acts_as_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,34 @@ class BotToolCall < ActiveRecord::Base # rubocop:disable Lint/ConstantDefinition
bot_chat.with_model('claude-3-5-haiku-20241022')
expect(bot_chat.reload.model_id).to eq('claude-3-5-haiku-20241022')
end

it 'cleans up incomplete tool interactions with custom message association name' do
bot_chat = Assistants::BotChat.create!(model: model)

bot_chat.bot_messages.create!(role: 'user', content: 'Do multiple calculations')

tool_call_msg = bot_chat.bot_messages.create!(role: 'assistant', content: nil)
tool_call1 = tool_call_msg.bot_tool_calls.create!(
tool_call_id: 'call_custom_1',
name: 'calculator',
arguments: { expression: '2 + 2' }.to_json
)
tool_call_msg.bot_tool_calls.create!(
tool_call_id: 'call_custom_2',
name: 'calculator',
arguments: { expression: '3 + 3' }.to_json
)

bot_chat.bot_messages.create!(
role: 'tool',
content: '4',
parent_tool_call: tool_call1
)

expect do
bot_chat.send(:cleanup_orphaned_tool_results)
end.to change { bot_chat.bot_messages.count }.by(-2)
end
end

describe 'namespaced chat models with custom foreign keys' do
Expand Down