Improve the 404 page #1031
Merged
Improve the 404 page #1031
+60
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Filter hidden versions (v2.0-preview no longer appears) - Sort versions by semver in descending order (newest first) - Add section headers to separate documentation versions from other resources - Include master version with descriptive note - Add "Latest" badge to current latest version - Fix grammar: "looking at one of the following sections:" - Add note about archived versions available in GitHub repository tags Fixes #1030 Signed-off-by: Jean du Plessis <jean@upbound.io>
Extract duplicated semver sorting logic from 404.html and version-dropdown-menu.html into a reusable utility partial at utils/sorted-versions.html. This eliminates 61 lines of duplicated code and establishes a single source of truth for version filtering and sorting logic. Benefits: - Reduces code duplication across templates - Improves maintainability (changes in one place) - Follows established project pattern for utility partials - Ensures consistency between 404 page and version dropdown Signed-off-by: Jean du Plessis <jean@upbound.io>
✅ Deploy Preview for crossplane ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Update version sorting to display master at the top of the list, before stable releases. This makes the unreleased upcoming version more prominent for users who want bleeding-edge documentation. Signed-off-by: Jean du Plessis <jean@upbound.io>
jbw976
approved these changes
Dec 8, 2025
Member
jbw976
left a comment
jbw976
left a comment
There was a problem hiding this comment.
awesome @jeanduplessis, this is definitely an improvement over the current 404 page! thanks for making this happen! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1030 - Improves the 404 page by filtering hidden versions, organizing content logically, and adding helpful navigation hints.
Changes
Additional refactoring:
utils/sorted-versions.htmlpartial