Skip to content

Fix #8983 FN containerOutOfBounds (passing empty init list) #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chrchr-github wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix #8983 FN containerOutOfBounds (passing empty init list) #8055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9569af
Fix #8983 FN containerOutOfBounds (passing empty init list)
web-flow Dec 20, 2025
dc38311
Format
web-flow Dec 20, 2025
4329212
Format
web-flow Dec 20, 2025
6021104
Format
web-flow Dec 20, 2025
b9d4a8b
Format
web-flow Dec 20, 2025
49c9b90
Fix
web-flow Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions lib/valueflow.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6884,6 +6884,26 @@ static void valueFlowContainerSize(const TokenList& tokenlist,
}
for (const ValueFlow::Value& value : values)
setTokenValue(tok, value, settings);
}
else if (Token::Match(tok->previous(), ",|( {")) {
int nArg{};
if (const Token* funcTok = getTokenArgumentFunction(tok, nArg)) {
if (const Function* func = funcTok->function()) {
if (const Variable* var = func->getArgumentVar(nArg)) {
if (var->valueType() && var->valueType()->container && var->valueType()->container->size_templateArgNo < 0) {
std::vector<ValueFlow::Value> values = getInitListSize(tok, var->valueType(), settings, true);
ValueFlow::Value tokValue;
tokValue.valueType = ValueFlow::Value::ValueType::TOK;
tokValue.tokvalue = tok;
tokValue.setKnown();
values.push_back(std::move(tokValue));

for (const ValueFlow::Value &value : values)
setTokenValue(tok, value, settings);
}
}
}
}
} else if (Token::Match(tok, ";|{|} %var% =") && Token::Match(tok->tokAt(2)->astOperand2(), "[({]") &&
// init list
((tok->tokAt(2) == tok->tokAt(2)->astOperand2()->astParent() && !tok->tokAt(2)->astOperand2()->astOperand2() && tok->tokAt(2)->astOperand2()->str() == "{") ||
Expand Down
22 changes: 22 additions & 0 deletions test/teststl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,6 +945,28 @@ class TestStl : public TestFixture {
" (void)v[0];\n"
"}\n");
ASSERT_EQUALS("", errout_str());

checkNormal("int f(const std::vector<int>& v) {\n" // #8983
" return v[2];\n"
"}\n"
"int g() {\n"
" return f({});\n"
"}\n"
"int h() {\n"
" return f({ 1, 2 });\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2:13]: error: Out of bounds access in 'v[2]', if 'v' size is 2 and '2' is 2 [containerOutOfBounds]\n"
"[test.cpp:2:13]: error: Out of bounds access in expression 'v[2]' because 'v' is empty. [containerOutOfBounds]\n",
errout_str());

checkNormal("int f(int x, const std::vector<int>& v) {\n"
" return x + v[0];\n"
"}\n"
"int g() {\n"
" return f(1, {});\n"
"}\n");
ASSERT_EQUALS("[test.cpp:2:17]: error: Out of bounds access in expression 'v[0]' because 'v' is empty. [containerOutOfBounds]\n",
errout_str());
}

void outOfBoundsSymbolic()
Expand Down
Loading