Skip to content

Conversation

@cicoyle
Copy link
Contributor

@cicoyle cicoyle commented Jan 5, 2026

* Adding a Flux based subscribeToEvents method

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Simplify GRPC stream handling

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Simplify Javadoc

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Fix unit tests and simplify implementation

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Adding event subscriber stream observer to simplify subscription logic

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Use start() method to start stream subscription

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Add unit test for event suscriber observer

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Improve the tests a little bit

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Remove the unnecessary method

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Improve error handling and use CloudEvent wrapper

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Fix unit tests asserts

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

* Adjust Java examples for Subscriber

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>

---------

Signed-off-by: Artur Ciocanu <artur.ciocanu@gmail.com>
@cicoyle cicoyle requested review from a team as code owners January 5, 2026 14:51
salaboy
salaboy previously approved these changes Jan 5, 2026
Copy link
Collaborator

@salaboy salaboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
salaboy
salaboy previously approved these changes Jan 6, 2026
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
@cicoyle cicoyle merged commit 75e13de into dapr:release-1.16 Jan 6, 2026
10 checks passed
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

❌ Patch coverage is 88.77551% with 11 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.16@b0594de). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...al/subscription/EventSubscriberStreamObserver.java 88.75% 6 Missing and 3 partials ⚠️
...k/src/main/java/io/dapr/client/DaprClientImpl.java 88.88% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##             release-1.16    #1613   +/-   ##
===============================================
  Coverage                ?   79.57%           
  Complexity              ?     2080           
===============================================
  Files                   ?      256           
  Lines                   ?     6365           
  Branches                ?      654           
===============================================
  Hits                    ?     5065           
  Misses                  ?      959           
  Partials                ?      341           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants