-
Notifications
You must be signed in to change notification settings - Fork 32
Remove chart tool, search-vector and search-indicators (rich metadata version) #147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @keyurva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on streamlining the DataCommons Multi-Client Proxy by removing obsolete functionalities. It eliminates the chart generation capabilities and unifies the search indicator logic to solely use the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request performs a significant cleanup by removing the chart generation tool and consolidating the search logic. It removes two different search implementations (search-vector and the rich metadata version of search-indicators), simplifying the DCClient and related components. The changes are consistently applied across the application, data models, and tests. My review focuses on some remaining code artifacts from this refactoring, such as outdated method names and docstrings, to further improve code clarity and maintainability. I also noted a minor duplication in one of the test files. Overall, this is a great simplification of the codebase.
clincoln8
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for the cleanup Keyur!
In the PR description, can you mention that we're removing support for custom dc users to rely on search-vector. This means in order to be compatible for MCP, they must be synced past the PR that added search-indicators into the website flask server.
Done. |
Uh oh!
There was an error while loading. Please reload this page.