Skip to content

Conversation

@keyurva
Copy link
Contributor

@keyurva keyurva commented Jan 21, 2026

  • Also removes the package publishing action since we are now publishing it differently (via github tags).
  • Since this removes support for the old search-vector endpoint, custom DC users must use a version newer than the 2025-09-08 release: 2025-09-08 Custom DC stable release website#5479

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @keyurva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on streamlining the DataCommons Multi-Client Proxy by removing obsolete functionalities. It eliminates the chart generation capabilities and unifies the search indicator logic to solely use the search-indicators endpoint. This change reduces technical debt and simplifies the architecture by removing a dual-endpoint search mechanism and an entire feature set that is no longer needed.

Highlights

  • Chart Tool Removal: The entire chart generation tool, including all associated data models (e.g., BaseChart, BarChart, LineChart) and the get_datacommons_chart_config function, has been completely removed from the codebase.
  • Search Endpoint Consolidation: The legacy search-vector endpoint and the use_search_indicators_endpoint configuration toggle have been eliminated. The system now exclusively utilizes the search-indicators endpoint for all indicator search operations, simplifying the search mechanism.
  • Codebase Simplification: Significant amounts of code related to the deprecated chart tool and the older search endpoint have been removed, leading to a leaner and more maintainable codebase.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs a significant cleanup by removing the chart generation tool and consolidating the search logic. It removes two different search implementations (search-vector and the rich metadata version of search-indicators), simplifying the DCClient and related components. The changes are consistently applied across the application, data models, and tests. My review focuses on some remaining code artifacts from this refactoring, such as outdated method names and docstrings, to further improve code clarity and maintainability. I also noted a minor duplication in one of the test files. Overall, this is a great simplification of the codebase.

Copy link
Contributor

@clincoln8 clincoln8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the cleanup Keyur!
In the PR description, can you mention that we're removing support for custom dc users to rely on search-vector. This means in order to be compatible for MCP, they must be synced past the PR that added search-indicators into the website flask server.

@keyurva
Copy link
Contributor Author

keyurva commented Jan 22, 2026

In the PR description, can you mention that we're removing support for custom dc users to rely on search-vector. This means in order to be compatible for MCP, they must be synced past the PR that added search-indicators into the website flask server.

Done.

@keyurva keyurva merged commit 40d25ad into datacommonsorg:main Jan 22, 2026
8 of 9 checks passed
@keyurva keyurva deleted the cleanup branch January 22, 2026 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants