fix: raise error when table declaration fails due to permissions

[dimitri-yatsenko]

Summary

Fix silent failure when table declaration fails due to insufficient permissions.

Problem

When creating a table with cross-schema foreign keys, if the user lacks REFERENCES privilege on the parent schema, the table creation would fail silently:

try:
    self.connection.query(sql)
except AccessError:
    # skip if no create privilege
    return  # <-- Silent failure!

Users only discovered the problem when trying to query the non-existent table later.

Solution

Only suppress AccessError if the table already exists (idempotent declaration). Otherwise, raise with a helpful message:

except AccessError:
    if self.is_declared:
        return  # Table exists, suppress (idempotent)
    raise AccessError(
        f"Cannot declare table {self.full_table_name}. "
        f"Check that you have CREATE privilege on schema `{self.database}` "
        f"and REFERENCES privilege on any referenced parent tables."
    )

Behavior

Scenario	Before	After
Table exists, no CREATE privilege	Silent return ✓	Silent return ✓
Table doesn't exist, no CREATE privilege	Silent return ✗	Raises AccessError ✓
Table doesn't exist, no REFERENCES privilege	Silent return ✗	Raises AccessError ✓

Closes #1161

---

🤖 Generated with Claude Code