NODEJS-696: Migrate Travis CI to Github Action #448
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,84 @@ | ||||||||
| name: Lint, TS Transpile, and Unit Tests, Migrated from Travis CI | ||||||||
|
|
||||||||
| on: | ||||||||
| push: | ||||||||
| pull_request: | ||||||||
|
|
||||||||
| jobs: | ||||||||
| eslint: | ||||||||
| name: Run eslint | ||||||||
| runs-on: ubuntu-22.04 | ||||||||
| steps: | ||||||||
| - uses: actions/checkout@v4 | ||||||||
| - uses: actions/setup-node@v4 | ||||||||
| with: | ||||||||
| node-version: 18.x | ||||||||
| cache: 'npm' | ||||||||
| - run: npm install -g eslint@4 | ||||||||
| - run: npm run eslint | ||||||||
|
|
||||||||
| typescript-49: | ||||||||
| name: TypeScript 4.9 generation and compilation tests | ||||||||
| runs-on: ubuntu-22.04 | ||||||||
| steps: | ||||||||
| - uses: actions/checkout@v4 | ||||||||
| - uses: actions/setup-node@v4 | ||||||||
| with: | ||||||||
| node-version: 18.x | ||||||||
| cache: 'npm' | ||||||||
|
|
||||||||
| - run: npm install | ||||||||
|
|
||||||||
| - run: npm install typescript@4.9.x --no-save | ||||||||
|
|
||||||||
| - run: | | ||||||||
| pushd test/unit/typescript/ | ||||||||
| npx tsc -p . | ||||||||
| node -e "require('./api-generation-test').generate()" > generated.ts | ||||||||
| npx tsc generated.ts | ||||||||
|
|
||||||||
| typescript-latest: | ||||||||
| name: TypeScript (latest) generation and compilation tests | ||||||||
| runs-on: ubuntu-22.04 | ||||||||
| steps: | ||||||||
| - uses: actions/checkout@v4 | ||||||||
| - uses: actions/setup-node@v4 | ||||||||
| with: | ||||||||
| node-version: 18.x | ||||||||
| cache: 'npm' | ||||||||
| - run: npm install | ||||||||
| - run: npm install typescript --no-save # installs the newest version | ||||||||
| - run: | | ||||||||
| pushd test/unit/typescript/ | ||||||||
| npx tsc -p . | ||||||||
| node -e "require('./api-generation-test').generate()" > generated.ts | ||||||||
| npx tsc generated.ts | ||||||||
|
|
||||||||
| unit-tests: | ||||||||
| name: Unit tests (Node.js ${{ matrix.node }}) | ||||||||
| runs-on: ubuntu-22.04 | ||||||||
| strategy: | ||||||||
| matrix: | ||||||||
| node: [18.x, 20.x, 22.x, 24.x] | ||||||||
| steps: | ||||||||
| - uses: actions/checkout@v4 | ||||||||
| - uses: actions/setup-node@v4 | ||||||||
| with: | ||||||||
| node-version: ${{ matrix.node }} | ||||||||
| cache: 'npm' | ||||||||
| - run: npm install | ||||||||
| - run: npm test | ||||||||
|
|
||||||||
|
|
||||||||
| unit-latest-deps: | ||||||||
| name: Unit tests w/ latest dependencies - Node.js 20.x | ||||||||
| runs-on: ubuntu-22.04 | ||||||||
| steps: | ||||||||
| - uses: actions/checkout@v4 | ||||||||
| - uses: actions/setup-node@v4 | ||||||||
| with: | ||||||||
| node-version: 20.x | ||||||||
|
There was a problem hiding this comment. [nitpick] The
Suggested change
Collaborator
Author
There was a problem hiding this comment. Will the next GH Action job pick up the cached latest dependencies instead of the fixed dependencies in the package-lock.json? |
||||||||
| - run: rm package-lock.json | ||||||||
| - run: rm -rf node_modules | ||||||||
| - run: npm install | ||||||||
| - run: npm test | ||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using
--no-savewithnpm installin CI is redundant since the package.json won't be committed from the CI environment. Consider removing the--no-saveflag for cleaner workflow configuration.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanted to make it clear that version 4.9 overrides