Add comments microservice #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davert0
reviewed
Nov 16, 2025
Owner
There was a problem hiding this comment.
Юзкейсы - это бизнес-логика приложения. Обычно логирование к бизнес-логике не относится, но у тебя тут как-будто аудитлог, то есть бизнесовое требование сохранять все действия в сервисе. В таком случае лучше это назвать либо HistoryRecord, либо Event, либо AuditLog, чтобы можно было различать с системным логированием.
Также факт логирования у тебя не происходит отдельно сам по себе, поэтому это лучше вынести в сервисный слой
| self.log_use_case = log_use_case | ||
|
|
||
| async def execute(self, post_id: int, content: Optional[str] = None) -> Comment: | ||
| existing_comment = await self.comment_repository.get_by_id(post_id=post_id) |
Owner
There was a problem hiding this comment.
тут и везде - если есть две записи в бд, которые не должны существовать отдельно друг от друга (в данном случае обновление комментария и лог об этом) то это нужно оборачивать в транзакцию
|
|
||
|
|
||
| db_name = await conn.fetchval("SELECT current_database()") | ||
| print(f"📡 Connected to database: {db_name}") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.