Skip to content

issue-694 Added support for del operator in a dbzero.list #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sigsegvdev wants to merge 1 commit into from
Closed

issue-694 Added support for del operator in a dbzero.list #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions python_tests/test_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,3 +546,24 @@ def test_append_to_random_lists(db0_autocommit_fixture):
def test_list_tuple_indexed_access(db0_fixture):
db0_list = db0.list([1, 2, 3, 5, 6, 7, 8])
assert db0_list[(1, 3, 4)] == [2, 5, 6]


def test_list_delitem(db0_fixture):
l = db0.list(range(10))
del l[0]
assert l == [1, 2, 3, 4, 5, 6, 7, 8, 9]
del l[-1]
assert l == [1, 2, 3, 4, 5, 6, 7, 8]
del l[2]
assert l == [1, 2, 4, 5, 6, 7, 8]

# Check del unrefs objects
obj = MemoTestClass(123)
obj_uuid = db0.uuid(obj)
l[0] = obj
del l[0]
del obj
db0.commit()
with pytest.raises(Exception):
obj = db0.fetch(obj_uuid)

3 changes: 3 additions & 0 deletions src/dbzero/bindings/python/collections/CollectionMethods.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ namespace db0::python
index = py_obj->ext().size() -1;
} else if (nargs == 1) {
index = PyLong_AsLong(args[0]);
if (PyErr_Occurred()) {
return nullptr;
}
} else {
PyErr_SetString(PyExc_TypeError, "pop() takes zero or one argument.");
return NULL;
Expand Down
33 changes: 18 additions & 15 deletions src/dbzero/object_model/list/List.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,6 @@ namespace db0::object_model

List::ObjectSharedPtr List::pop(FixtureLock &fixture, std::size_t i)
{
if (size() == 0) {
THROWF(db0::InputException) << "Cannot pop from empty container ";
}
Copy link
Collaborator Author

@sigsegvdev sigsegvdev Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this check because it's redundant and also cause inconsistent behavior, where we get a different exception depending whether the list is empty or not - this is not how standard python list works

if (i >= size()) {
THROWF(db0::IndexException) << "Index out of range: " << i;
}
Expand All @@ -100,19 +97,25 @@ namespace db0::object_model
THROWF(db0::IndexException) << "Index out of range: " << i;
}

// recognize type ID from language specific object
auto type_id = LangToolkit::getTypeManager().getTypeId(lang_value);
// NOTE: packed storage not supported for list items
auto pre_storage_class = TypeUtils::m_storage_class_mapper.getPreStorageClass(type_id, false);
StorageClass storage_class;
if (pre_storage_class == PreStorageClass::OBJECT_WEAK_REF) {
storage_class = db0::getStorageClass(pre_storage_class, *fixture, lang_value);
} else {
storage_class = db0::getStorageClass(pre_storage_class);
}

auto [storage_class_value, value] = (*this)[i];
v_bvector::setItem(i, createListItem<LangToolkit>(*fixture, type_id, lang_value, storage_class, getMemberFlags()));
if (lang_value) {
// recognize type ID from language specific object
auto type_id = LangToolkit::getTypeManager().getTypeId(lang_value);
// NOTE: packed storage not supported for list items
auto pre_storage_class = TypeUtils::m_storage_class_mapper.getPreStorageClass(type_id, false);
StorageClass storage_class;
if (pre_storage_class == PreStorageClass::OBJECT_WEAK_REF) {
storage_class = db0::getStorageClass(pre_storage_class, *fixture, lang_value);
} else {
storage_class = db0::getStorageClass(pre_storage_class);
}

v_bvector::setItem(i, createListItem<LangToolkit>(*fixture, type_id, lang_value, storage_class, getMemberFlags()));
}
else {
// del operator used
this->erase(i);
}
unrefMember<LangToolkit>(*fixture, storage_class_value, value);
}

Expand Down
Loading