-
Notifications
You must be signed in to change notification settings - Fork 14
Feat: WebGL, extract Threading/Task APIs, gate unsupported systems, and align async model #6802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
NickKhalow
wants to merge
44
commits into
shape/web_version
Choose a base branch
from
feat/webgl_build_setup
base: shape/web_version
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebGL runs in a single-threaded environment and does not support
System.Threading,System.Threading.Tasks, blocking synchronization primitives, file system access, or native sockets.This PR removes or gates incompatible APIs, replaces them with WebGL-safe abstractions, and enforces compile-time correctness to prevent regressions.
Summary of Changes
Threading & Synchronization
System.Threadingprimitives (SemaphoreSlim,Interlocked, thread pool usage).DCLSemaphoreSlim,DCLInterlocked,DCLTask).MultiThreadSyncand ECS locking systems are excluded from WebGL builds (#if !UNITY_WEBGL), as WebGL execution is single-threaded by design.Task to UniTask migration
System.Threading.Tasksusage across runtime and infrastructure code.Task/ValueTaskAPIs withUniTask.Task.WebGL platform gating
Explicitly excluded unsupported systems from WebGL:
Introduced
IDiskCache.Nullfor WebGL to preserve API shape without runtime side effects.WebSocket / networking
Taskand thread-based synchronization.SemaphoreSlimandInterlockedwith WebGL-safe equivalents.Authentication & bootstrap cleanup
Simplified Web3 authentication flow:
IWeb3VerifiedAuthenticatorwithIWeb3Authenticator.Adjusted auto-login and bootstrap flows to the new async model.
Tests & assembly definitions
Debugging & diagnostics
Why this change
Follow-ups