-
Notifications
You must be signed in to change notification settings - Fork 14
feat: [Re-Discover / Places Section] Integrate the new places endpoint #6837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
…over-places-sub-section
…over-places-sub-section
… JumpInWorldLink to DecentralandUrl
… JumpInWorldLink to DecentralandUrl (II)
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
daniele-dcl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
balducciv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following test scenarios passed, but only when interacting in Genesis Plaza. This is a reported issue which will be fixed by backend. Context here.
Online users in the mini-card
Can see users online in the scene user is in
Can see users online in scenes user is not in
When there is only 1 user in the scene, the counter is 1
When there are more than 1 users on the scene, the counter matches the amount of users in scene
When there are no friends online in the scene-card, no profile icon displays next to the online users
When there are friends online in the selected scene-card, the profile icon displays next to the online users
These scenarios did not pass due to the backend issue and will be retested once this is fixed
World - places mini-card
Can see users online in the scene card of the world user is in
Can see users online in the world user is not in
When there is only 1 user in the scene, the counter is 1
When there are more than 1 user in the world, the counter matches the amount of users in world
When there are no friends online in the places mini-card of the world, no profile icon displays next to the online users
When there are friends online in the selected places mini-card of the world, the profile icon displays next to the online users
Browse
Online users and friends are seen in the mini-card when browsing categories
Online users and friends are seen in the mini-card when searching places
Online users and friends are seen in the mini-card when browsing the Favorites tab
Online users and friends are seen in the mini-card when browsing the Last visited tab
Online users and friends are seen in the mini-card when browsing the My Places tab
Pull Request Description
Fix #6799
What does this PR change?
This PR is part of the "Re-Discover" shape's implementation.
It integrates the new places endpoint that returns places and worlds together and, in addition, it also returns the list of users connected to the place which allows us to show in the card what friends are currently connected.
Test Steps
--debug --discover --dclenv zone.Code Review Reference
Please review our Code Review Standards before submitting.