Skip to content

Conversation

@sandrade-dcl
Copy link
Contributor

@sandrade-dcl sandrade-dcl commented Jan 22, 2026

Pull Request Description

Fix #6799

What does this PR change?

This PR is part of the "Re-Discover" shape's implementation.
It integrates the new places endpoint that returns places and worlds together and, in addition, it also returns the list of users connected to the place which allows us to show in the card what friends are currently connected.

image image

Test Steps

  1. Execute the build using these app args: --debug --discover --dclenv zone.
  2. Open the "Places" section (first section inside the Start Menu).
  3. Navigate inside Places section, go through the diferent sub-sections, use the filters, the categories, the search bar, etc.
  4. Check that all places cards are loaded correctly and that now we are including both places and worlds in the searchs.
  5. Also, check that the new "friends connected" counter in the card works correctly.

Code Review Reference

Please review our Code Review Standards before submitting.

@sandrade-dcl sandrade-dcl self-assigned this Jan 22, 2026
@sandrade-dcl sandrade-dcl added do not merge shape-up It has been shaped and is awaiting the cycle. labels Jan 22, 2026
@github-actions
Copy link
Contributor

badge

New build in progress, come back later!

Base automatically changed from feat/re-use-place-card-view-in-places-section to dev January 22, 2026 22:36
@sandrade-dcl sandrade-dcl marked this pull request as ready for review January 23, 2026 11:32
@sandrade-dcl sandrade-dcl requested review from a team as code owners January 23, 2026 11:32
Copy link
Contributor

@daniele-dcl daniele-dcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

Copy link

@balducciv balducciv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following test scenarios passed, but only when interacting in Genesis Plaza. This is a reported issue which will be fixed by backend. Context here.

Online users in the mini-card

Can see users online in the scene user is in
Can see users online in scenes user is not in
When there is only 1 user in the scene, the counter is 1
When there are more than 1 users on the scene, the counter matches the amount of users in scene
When there are no friends online in the scene-card, no profile icon displays next to the online users
When there are friends online in the selected scene-card, the profile icon displays next to the online users

These scenarios did not pass due to the backend issue and will be retested once this is fixed

World - places mini-card
Can see users online in the scene card of the world user is in
Can see users online in the world user is not in
When there is only 1 user in the scene, the counter is 1
When there are more than 1 user in the world, the counter matches the amount of users in world
When there are no friends online in the places mini-card of the world, no profile icon displays next to the online users
When there are friends online in the selected places mini-card of the world, the profile icon displays next to the online users

Browse
Online users and friends are seen in the mini-card when browsing categories
Online users and friends are seen in the mini-card when searching places
Online users and friends are seen in the mini-card when browsing the Favorites tab
Online users and friends are seen in the mini-card when browsing the Last visited tab
Online users and friends are seen in the mini-card when browsing the My Places tab

Pr-6837.users.online.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shape-up It has been shaped and is awaiting the cycle.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Re-Discover / Places Section] Integrate the new places endpoint

6 participants