fix: check ALL validators with queued CARs after consensus decision #148
+398
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix only checked validators that were included in the decided cut. This missed validators that had queued CARs but were not part of the cut. Changes: - Add get_validators_with_queued_cars() method to PrimaryState - Update consensus decision handler to check ALL validators with queued CARs, not just those in the decided cut - Add comprehensive tests for the new behavior This ensures that no CARs are left stranded in the queue when a consensus decision is processed.
The previous fix only processed CARs at exactly the expected position in a single pass. This missed chains of queued CARs where processing position N should make position N+1 ready, then N+2, etc. Changes: - Wrap queued CAR processing in a loop that continues until no more CARs become ready - Add test_queued_car_chain_processing test to verify chain handling This ensures that after a consensus decision syncs positions, ALL queued CARs in a chain are processed, not just the first one.
When consensus decision is processed, queued CARs are processed which may reach attestation threshold. At that point, try_form_cut() is called but returns early because pipeline_stage is still Proposing. After finalize_height() switches to Collecting stage, we need to call try_form_cut() again to form cuts from any CARs that were attested during the queued CAR processing loop. This fixes the consensus liveness bug where height 3 gets stuck with all validators voting NIL because no cuts were being produced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get_validators_with_queued_cars()method to check ALL validators with queued CARsTest plan
test_get_validators_with_queued_carstesttest_queued_cars_from_validators_not_in_cuttest