test: exclude power state checks from complex test #1841

eofff · 2025-12-19T10:01:22Z

Description

Exclude power state checks from complex test. Write new e2e power state test.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

The code is covered by unit tests.
e2e tests passed.
Documentation updated according to the changes.
Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: chore
summary: Exclude power state checks from complex test. Write new e2e power state test.
impact_level: low

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

hardcoretime · 2025-12-28T11:10:19Z

test/e2e/internal/util/vm.go

+func StopVirtualMachineFromOS(f *framework.Framework, vm *v1alpha2.VirtualMachine) {
+	GinkgoHelper()
+
+	_, err := f.SSHCommand(vm.Name, vm.Namespace, "nohup sh -c \"sleep 5 && sudo init 0\" > /dev/null 2>&1 &")


It seems that the solution does not work on Alpine OS. If this is a common solution, it should work on other operating systems.

hardcoretime · 2025-12-28T11:11:06Z

test/e2e/internal/util/vm.go

+	_, err := f.SSHCommand(vm.Name, vm.Namespace, "nohup sh -c \"sleep 5 && sudo init 0\" > /dev/null 2>&1 &")
+	Expect(err).To(SatisfyAny(
+		Not(HaveOccurred()),
+		MatchError(MatchError(ContainSubstring("unexpected EOF"))),


Why is this error expected here?

hardcoretime · 2025-12-28T11:13:25Z

test/e2e/internal/util/vm.go

+	_, err := f.SSHCommand(vm.Name, vm.Namespace, "nohup sh -c \"sleep 5 && sudo reboot\" > /dev/null 2>&1 &")
+	Expect(err).To(SatisfyAny(
+		Not(HaveOccurred()),
+		MatchError(MatchError(ContainSubstring("unexpected EOF"))),


Why is this error expected here?

hardcoretime · 2025-12-28T11:18:16Z

test/e2e/internal/util/vm.go

 	Expect(err).NotTo(HaveOccurred())
 }

+func RebootVirtualMachineByPodDeletion(f *framework.Framework, vm *v1alpha2.VirtualMachine) {


Why does it work with length and indexes, instead of an active pod?

hardcoretime · 2025-12-28T11:22:46Z

test/e2e/internal/util/vm.go


 	opts := []vmopbuilder.Option{
-		vmopbuilder.WithGenerateName("vmop-e2e-"),
+		vmopbuilder.WithGenerateName("vmop-start-"),


It should be in the same style as reboot, with a prefix. You can create the prefix constants in one place.

hardcoretime · 2025-12-28T12:10:15Z

test/e2e/vm/power_state.go

+		var namespaceName string
+		switch runPolicy {
+		case v1alpha2.AlwaysOnPolicy:
+			namespaceName = "power-aon"
+		case v1alpha2.AlwaysOnUnlessStoppedManually:
+			namespaceName = "power-aon-usm"
+		case v1alpha2.ManualPolicy:
+			namespaceName = "power-manual"
+


Suggested change

var namespaceName string

switch runPolicy {

case v1alpha2.AlwaysOnPolicy:

namespaceName = "power-aon"

case v1alpha2.AlwaysOnUnlessStoppedManually:

namespaceName = "power-aon-usm"

case v1alpha2.ManualPolicy:

namespaceName = "power-manual"

var namespaceSuffix string

switch runPolicy {

case v1alpha2.AlwaysOnPolicy:

namespaceSuffix = "always-on"

case v1alpha2.AlwaysOnUnlessStoppedManually:

namespaceSuffix = "unless-stopped-manually"

case v1alpha2.ManualPolicy:

namespaceSuffix = "manual"

hardcoretime · 2025-12-28T12:24:56Z

test/e2e/vm/power_state.go

+
+			util.UntilObjectPhase(string(v1alpha2.MachineRunning), framework.LongTimeout, t.VM)
+			util.UntilObjectPhase(string(v1alpha2.BlockDeviceAttachmentPhaseAttached), framework.MiddleTimeout, t.VMBDA)
+			util.UntilVMAgentReady(crclient.ObjectKeyFromObject(t.VM), framework.ShortTimeout)


Is it necessary in this test case?

hardcoretime · 2025-12-28T12:29:44Z

test/e2e/vm/power_state.go

+	t.VMOPStop = vmopbuilder.New(
+		vmopbuilder.WithGenerateName("vmop-stop-"),
+		vmopbuilder.WithNamespace(t.VM.Namespace),
+		vmopbuilder.WithType(v1alpha2.VMOPTypeStop),
+		vmopbuilder.WithVirtualMachine(t.VM.Name),
+	)
+
+	t.VMOPStart = vmopbuilder.New(
+		vmopbuilder.WithGenerateName("vmop-start-"),
+		vmopbuilder.WithNamespace(t.VM.Namespace),
+		vmopbuilder.WithType(v1alpha2.VMOPTypeStart),
+		vmopbuilder.WithVirtualMachine(t.VM.Name),
+	)
+
+	t.VMOPRestart = vmopbuilder.New(
+		vmopbuilder.WithGenerateName("vmop-restart-"),
+		vmopbuilder.WithNamespace(t.VM.Namespace),
+		vmopbuilder.WithType(v1alpha2.VMOPTypeRestart),
+		vmopbuilder.WithVirtualMachine(t.VM.Name),
+	)


Why don't you use the functions from the util.go file?

hardcoretime · 2025-12-28T12:37:23Z

test/e2e/vm/power_state.go

+			if t.VM.Spec.RunPolicy == v1alpha2.AlwaysOnPolicy {
+				return // No need to start VM if it's AlwaysOn policy
+			}
+
+			util.StartVirtualMachine(f, t.VM)
+			util.UntilVMAgentReady(crclient.ObjectKeyFromObject(t.VM), framework.MiddleTimeout)


Suggested change

if t.VM.Spec.RunPolicy == v1alpha2.AlwaysOnPolicy {

return // No need to start VM if it's AlwaysOn policy

}

util.StartVirtualMachine(f, t.VM)

util.UntilVMAgentReady(crclient.ObjectKeyFromObject(t.VM), framework.MiddleTimeout)

if t.VM.Spec.RunPolicy != v1alpha2.AlwaysOnPolicy {

util.StartVirtualMachine(f, t.VM)

util.UntilObjectPhase(string(v1alpha2.MachineRunning), framework.ShortTimeout, t.VM)

}

hardcoretime · 2025-12-28T12:46:21Z

test/e2e/vm/power_state.go

+		})
+
+		By("Check VM can reach external network", func() {
+			network.CheckExternalConnectivity(f, t.VM.Name, network.ExternalHost, network.HTTPStatusOk)


Why are you excluding "CheckCiliumAgents"?

eofff added this to the v1.4.0 milestone Dec 19, 2025

github-actions bot assigned eofff Dec 19, 2025

eofff marked this pull request as ready for review December 19, 2025 10:01

eofff requested review from Isteb4k and fl64 as code owners December 19, 2025 10:01

eofff force-pushed the test/power-state-check branch from 19e556f to 5435a88 Compare December 19, 2025 13:10

eofff requested a review from hardcoretime December 24, 2025 08:13

Valeriy Khorunzhin added 2 commits December 24, 2025 11:20

add

d29c9ca

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

fix

f37fa61

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

eofff force-pushed the test/power-state-check branch from 5435a88 to f37fa61 Compare December 24, 2025 08:20

hardcoretime requested changes Dec 28, 2025

View reviewed changes

eofff marked this pull request as draft December 30, 2025 08:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: exclude power state checks from complex test #1841

test: exclude power state checks from complex test #1841

Uh oh!

eofff commented Dec 19, 2025 •

edited

Loading

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

hardcoretime Dec 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

test: exclude power state checks from complex test #1841

Are you sure you want to change the base?

test: exclude power state checks from complex test #1841

Uh oh!

Conversation

eofff commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

Changelog entries

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

eofff commented Dec 19, 2025 •

edited

Loading