Refine symex pointer unsoundness #8780
Open
+710
−699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
refine-symex-pointer-unsoundness
branch
from
889225b to
2dc63d4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8780 +/- ##
========================================
Coverage 80.00% 80.00%
========================================
Files 1700 1700
Lines 188257 188267 +10
Branches 73 73
========================================
+ Hits 150615 150628 +13
+ Misses 37642 37639 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tautschnig
force-pushed
the
refine-symex-pointer-unsoundness
branch
2 times, most recently
from
c954ba7 to
d48dfd7
Compare
We cannot soundly handle pointer offsets that are shared across threads, and will reject this in future to avoid unsound verification results. Here, however, the pointer offsets are not actually shared, so we can safely mark them `__CPROVER_thread_local`.
…ed pointers Reading and writing pointers is not not itself unsound, only the interaction with value sets may cause unsound results. Hence, do not reject programs that never dereference a shared pointer. Fixes: diffblue#8714 Fixes: diffblue#7957
Shared pointers may be updated in yet-to-be-executed threads.
tautschnig
force-pushed
the
refine-symex-pointer-unsoundness
branch
from
d48dfd7 to
7d44a79
Compare
There was a problem hiding this comment.
Pull request overview
This pull request refines the handling of symex pointer unsoundness in concurrent programs by marking specific variables as thread-local and updating test expectations to properly detect and report unsoundness issues.
- Added
__CPROVER_thread_localqualifier to register variables in weak memory model test files to ensure correct thread-local semantics - Updated test descriptors to detect pointer handling unsoundness in concurrent programs instead of silently passing or being marked as known bugs
- Enabled previously disabled pthread tests on OSX and FreeBSD platforms
Reviewed changes
Copilot reviewed 300 out of 428 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| regression/goto-instrument-wmm-core/ppc_*.c | Added __CPROVER_thread_local to register variables used in weak memory model tests |
| regression/cbmc-concurrency/*/test.desc | Updated test expectations to detect pointer unsoundness instead of passing or being marked as known bugs |
| regression/cbmc-concurrency/Makefile | Removed OSX and FreeBSD from pthread test exclusions |
| regression/cbmc-concurrency/CMakeLists.txt | Simplified platform check to only exclude Windows for pthread tests |
| regression/cbmc-library/realloc/test_03.desc | Changed from expecting failure to expecting success with --no-malloc-may-fail |
| regression/cbmc-concurrency/global_pointer1/ | Split test into multiple variants to test with/without pointer dereferencing |
| regression/book-examples/account/C10.desc | Changed from KNOWNBUG to CORE test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit-by-commit.
Fixes: #8714
Fixes: #7957