-
Notifications
You must be signed in to change notification settings - Fork 523
Fix/i18n issues #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
meifu2027
wants to merge
6
commits into
different-ai:dev
Choose a base branch
from
meifu2027:fix/i18n-issues
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix/i18n issues #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add translation functionality and close button to the language selector component - Update the dashboard page to use dynamic translated text - Integrate multi-language text on the plugin page - Add internationalization support to the session page - Implement language switching in the settings page - Create a modal component for language selection - Add language type definitions and manage current language state
- Add translation functionality and close button to the language selector component - Update the dashboard page to use dynamic translated text - Integrate multi-language text on the plugin page - Add internationalization support to the session page - Implement language switching in the settings page - Create a modal component for language selection - Add language type definitions and manage current language state
…ssues # Conflicts: # src/app/pages/session.tsx
- Add translation functionality and close button to the language selector component - Update the dashboard page to use dynamic translated text - Integrate multi-language text on the plugin page - Add internationalization support to the session page - Implement language switching in the settings page - Create a modal component for language selection - Add language type definitions and manage current language state
- Add translation functionality and close button to the language selector component - Update the dashboard page to use dynamic translated text - Integrate multi-language text on the plugin page - Add internationalization support to the session page - Implement language switching in the settings page - Create a modal component for language selection - Add language type definitions and manage current language state
Member
|
@meifu2027 we did a small refactor you'll need to rebase/merge your branch |
Member
|
Automated message: strong i18n push, but a few blockers:
PR is also CONFLICTING; please rebase on |
Member
|
would prefer to isolate this functionality purely in the settings from a UX perspective and not have state spread out across the app. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes and enhances the application's internationalization features:
Language Picker Modal: Fully functional language selection modal with close button.
Multi-Scenario Support: Translations now correctly apply across all pages and components, including Dashboard, Plugins, Session, Settings, and Templates.
Dynamic Language Switching: Users can switch languages in the settings, and the selected language persists across sessions.
Type Safety & State Management: Added language type definitions and centralized management of current language state.
Improved UX: Translated text dynamically updates when the user changes the language.
This ensures a seamless multi-language experience throughout the application.