-
Notifications
You must be signed in to change notification settings - Fork 2
Merge branch 'develop' #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Merge branch 'develop' #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4 to 5. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-java dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 5. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v5) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
- Creates hydra + DB models - Adds a migration to the DB - Creates hydra/model converters - Controller created with placeholders for all endpoints - Initial implementations of GET and POST
- Adds a created/updated to Adjunct - Modifies IiifLink to be IIIFLink - modifies CreateOrUpdateAdjunct to work with PUT
- Remove IIIF from the HydraModel class, along with using a Dictionary - set ExternalId to required - Create a dictionary to LanguageMap converter - Remove adjuncts from asset notification sender - Stop validating type value - Revert ResourceType.cs
- Adds finished and publicId - Removes modified - Updates migration
- Various naming/grammatical changes - Make iiifLink camel case - Remove unneeded paging values - Make get all return 404 if asset doesn't exist - Make ToLanguageMap nullable - Remove unneeded Sets - Remove DB length limit on iiif link - Move test class to db fixture
- use GetDescription over ToCamelCase - Spelling changes - Explicit ordering by id - Simplify null check
Only return Images Id to determine existance and order in db
Add initial external assets adjuncts work
Removes requirement for host env to be "Development". This is slightly riskier but allows that risk to be taken and simplifies some deployment scenarios. We will likely want to use other means for applying migrations in some prod environments
Allow migrations to be run in all envs
Remove validation rules from FluentValidator as this was already being done in controller. Also treat empty and null string as equivalent for easy of consuming API.
Property not required - Hydra model is only used in controller and that will always have the route params to determine AssetId.
This is no longer Asset specific. Also set a default value in appsettings.json to remove need for it to be set in all envs
Validates length not exceeded and contains no invalid chars
Use Lower("Id") as unique constraint while leaving Id as a standard,
case sensitive text field. The constraint prevents creation of adjuncts
that differ only by id, while the normal text field ensures that reads
are still case sensitive
Also added tests for existing UniqueConstraint parsing
This will correctly catch errors but means that they are formatted slightly differently from those via fluent validator
Adjunct bugfixes
…cache-5 Bump actions/cache from 4 to 5
…setup-dotnet-5 Bump actions/setup-dotnet from 4 to 5
…setup-java-5 Bump actions/setup-java from 4 to 5
Remove driver-opts from setup-buildx-actions, was required for old issue that should now be resolved
Bump packages in github actions
Allow adjunct @type to change
Rename IncludeRelevantMetadata() to IncludeRelationsForProjections() and include adjuncts in query
Tests for outputting external adjuncts
Output external adjunct on Manifests
Based on PR feedback - Orchestrator will check all image requests, call out system-wide maxWidth
Reject attempts to use value larger than system default and highlight how info.json uses maxWidth
ADR for `maxWidth` and `openFullMax`
Use ordering by id to match with API requests
Ensure adjunct ordering on Manifest
donaldgray
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.