Support passing arguments to urllib3 classes
#210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`urllib3`'s `PoolManager` and `ConnectionPool` provide useful settings like `tiemout` and `retries`. This allows users to pass a dictionary of kwargs to `ApiClient`, which will get passed to the `PoolManager`, which will then pass along any extra kwargs to the `ConnectionPool`, allowing for advanced configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
urllib3'sPoolManagerandConnectionPoolprovide useful settings liketiemoutandretries. This allows users to pass a dictionary of kwargs toApiClient, which will get passed to thePoolManager, which will then pass along any extra kwargs to theConnectionPool, allowing for advanced configuration.My goal is to be able to configure the underlying
ConnectionPoolto be able to handle some recent network issues that we have been having.