Compression Fixes & General Maintenance #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps users find files that shouldn't be compressed, for example wems being compressed due to old RPFM versions.
…mpressing the full payload regardless. ReadData(size) caused errors because N bytes would be read but treated as the entire file for decompression causing and end of stream error.
… which was preventing tests from completing.
…and System.Net.NameResolution references as they're are now provided by .NET.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored compression to be fully size-driven rather than decompressing the full payload, added more validation, and added more detailed compression logging to help users spot bugs with incorrectly compressed files (due to using older versions of RPFM compressing the wrong things). Hopefully this addresses the corruption issues users have reported.
The PR also includes other general maintenance things because an unreferenced class (how that got there I don't know?) in DbSchemaBuilder.cs was causing some test failures which would've caused the PR to fail, so figured it made sense to include the rest of the maintenance bits I'd done all in one.