Skip to content

Conversation

@motdotla
Copy link
Contributor

@motdotla motdotla commented May 2, 2025

No description provided.

@motdotla motdotla requested a review from Copilot May 2, 2025 17:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the dotenvx CLI integration by adding two new optional arguments, dotenv_path and override, to allow for more flexible execution of the binary. Key changes include:

  • Adding dotenv_path and override parameters to load_dotenvx and dotenvx_get.
  • Updating the command arguments based on the provided parameters.
  • Updating the changelog to reflect the new version and feature additions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/dotenvx/main.py Introduced dotenv_path and override parameters; updated function return type
CHANGELOG.md Updated version number and changelog entry for the new feature
Comments suppressed due to low confidence (1)

src/dotenvx/main.py:24

  • Changing load_dotenvx to return a boolean instead of the parsed JSON can break existing API contracts if clients expect the full parsed object. Consider updating the documentation or reverting the return value change to ensure consistency.
return True

@motdotla motdotla merged commit 0cd499b into main May 2, 2025
6 checks passed
@motdotla motdotla deleted the dotenv-values branch May 2, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants