Skip to content

Conversation

@tmat
Copy link
Member

@tmat tmat commented Dec 11, 2025

Move command completion configuration from definitions to implementations. Completion is not needed for command line parsing.
The completion often depends on the implementation of the command (e.g. NuGet package downloader, etc.).

The last commit switches the affected commands to a new pattern: instead of definitions being static classes and arguments, options and subcommands stored in static fields we instantiate command definitions.
This allows us to use inheritance for similar command definitions (e.g. package add and add package) and access their options/arguments in a strongly typed manner.

Will move all commands to the new pattern in follow up PRs.

@tmat tmat changed the base branch from main to release/10.0.2xx December 11, 2025 21:31
…essing their subcommands, options and arguments
@tmat tmat marked this pull request as ready for review December 15, 2025 16:45
@tmat tmat requested a review from a team as a code owner December 15, 2025 16:45
@tmat
Copy link
Member Author

tmat commented Dec 15, 2025

@MiYanni @baronfel ptal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant