-
Notifications
You must be signed in to change notification settings - Fork 5
feat: move from two-track to three-track container build #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the Dockerfile build structure from a two-track (builder, runtime) to a three-track build (builder concretization, builder installation, runtime). The key benefit is that custom version concretization now happens earlier in the build process, allowing concretization failures to surface before expensive installation steps are executed.
Key Changes
- Modified
builder_concretization_customto derive frombuilder_concretization_defaultinstead ofbuilder_installation_default, enabling earlier failure detection - Consolidated runtime stages by merging
runtime_concretization_*andruntime_installation_*into singleruntime_defaultandruntime_customstages - Updated documentation and ASCII diagram to reflect the new three-track architecture
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Initial plan * docs: update architecture.md mermaid diagram for three-track build Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Briefly, what does this PR introduce?
This PR changes slightly the build structure from a two-track (builder, runtime) build to more of a three-track build (builder default, builder custom, runtime).
This primarily allows for concretization of the builder custom phase before any installation is done. Since we've been having some failures at that stage, it's annoying to have to wait until the installation is far along. This will trigger those failures earlier.