Skip to content

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 15, 2025

Briefly, what does this PR introduce?

Needs:

This PR upgrades spack-packages to v2025.11.0, https://github.com/spack/spack-packages/releases/tag/v2025.11.0.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

No.

Does this PR change default behavior?

No.

Copilot AI review requested due to automatic review settings November 15, 2025 00:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the spack-packages dependency from v2025.07.0 to v2025.11.0, removing the need for previously cherry-picked commits that are now included in the new release.

  • Updated SPACKPACKAGES_VERSION to v2025.11.0
  • Cleared all cherry-picked commits as they are now part of the base release
  • Removed associated cherry-pick file mappings and descriptive comments

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc force-pushed the spack-packages-2025.11.0 branch 2 times, most recently from cdaa710 to 988a595 Compare November 20, 2025 16:37
Copilot AI review requested due to automatic review settings November 29, 2025 02:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc force-pushed the spack-packages-2025.11.0 branch from f2a976c to 0a605d2 Compare December 25, 2025 17:00
Copilot AI review requested due to automatic review settings December 25, 2025 18:05
@wdconinc wdconinc force-pushed the spack-packages-2025.11.0 branch from 0a605d2 to 1bb7d37 Compare December 25, 2025 18:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc force-pushed the spack-packages-2025.11.0 branch from 1bb7d37 to d9dfd84 Compare December 25, 2025 18:30
Copilot AI review requested due to automatic review settings December 25, 2025 20:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 26, 2025 01:29
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 26, 2025 04:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 28, 2025 19:15
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc force-pushed the spack-packages-2025.11.0 branch from 32a41af to c9f86ca Compare December 28, 2025 21:43
Copilot AI review requested due to automatic review settings December 29, 2025 03:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc requested a review from veprbl December 29, 2025 04:09
Copilot AI review requested due to automatic review settings December 29, 2025 19:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 30, 2025 13:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wdconinc wdconinc enabled auto-merge (squash) December 30, 2025 16:18
@wdconinc wdconinc changed the title Upgrade Spack Packages to v2025.11.0 chore: upgrade spack-packages to v2025.11.0 Dec 30, 2025
@wdconinc
Copy link
Contributor Author

Comparison:

12:40:34 wdconinc@menelaos ~ $ docker run --rm -it ghcr.io/eic/eic_ci:nightly bash -c 'du -sh /opt/software/linux-*/* | sort -h | tail'
115M    /opt/software/linux-x86_64_v2/py-scipy-1.16.0-3h37q7xry2ky3ldgqmqpcp7uqiunzmqp
123M    /opt/software/linux-x86_64_v2/pythia8-8.315-vyooop3m72kizt5ddnwts24j3zfhqzvm
128M    /opt/software/linux-x86_64_v2/g4realsurface-2.2-7pbzz3kycww3u7airf7r42d22wpxhfhg
133M    /opt/software/linux-x86_64_v2/git-2.48.1-75ehiolr7t2p3lqhvf6hkeb6tzusrof2
229M    /opt/software/linux-x86_64_v2/boost-1.88.0-hlidzutmz7uplxqoaa6tmfnz2tiuvcz5
235M    /opt/software/linux-x86_64_v2/geant4-11.3.2.east-6vuzwbahjodkkxpgwwhcfkpca2ctb6ja
316M    /opt/software/linux-x86_64_v2/python-3.13.5-imu4nycwgxq6f6ffns2xjdmvyb7x5xal
347M    /opt/software/linux-x86_64_v2/arrow-19.0.1-5zb2q4zzmcrcodmjyrmgq52okpd3uscc
520M    /opt/software/linux-x86_64_v2/root-6.38.00-447she4aapomzvbv6woowvin7twkct2e
681M    /opt/software/linux-x86_64_v2/g4emlow-8.6.1-kwc7wum5crq6kk5jc5tmhhxp7mvw55ct
12:40:51 wdconinc@menelaos ~ $ docker run --rm -it ghcr.io/eic/eic_ci:unstable-pr-35 bash -c 'du -sh /opt/software/linux-*/* | sort -h | tail'
107M    /opt/software/linux-x86_64_v2/py-onnxruntime-1.20.2-lbmybak3kpjfenan7hlkaa5cfbucquvi
109M    /opt/software/linux-x86_64_v2/py-scipy-1.16.3-nm6kr4k3sihewyppgl6km4tigh3ludc2
123M    /opt/software/linux-x86_64_v2/pythia8-8.315-oay5mm5eqxp4uo2mnordluyqc2yd773h
128M    /opt/software/linux-x86_64_v2/g4realsurface-2.2-7pbzz3kycww3u7airf7r42d22wpxhfhg
133M    /opt/software/linux-x86_64_v2/git-2.48.1-axbm7dgdq26ll6rxau3hime6empaxziu
229M    /opt/software/linux-x86_64_v2/boost-1.88.0-z2vdrl27s4eggbryokod33uzdhkhhnlw
247M    /opt/software/linux-x86_64_v2/geant4-11.3.2.east-h6wfkqo74qzznxkqz4lyysdztz6pi4w7
317M    /opt/software/linux-x86_64_v2/python-3.13.8-4j2apxg7wrlbznypmpsty56mfkfdyowv
645M    /opt/software/linux-x86_64_v2/root-6.38.00-hlln3yuyy5faqg3nkyvr3fu4f7mj6wdg
681M    /opt/software/linux-x86_64_v2/g4emlow-8.6.1-kwc7wum5crq6kk5jc5tmhhxp7mvw55ct
  • It seems we lost arrow... Arguably a good thing since I don't think we are using it :-)
  • ROOT is larger since the default for C++ modules was changed and pre-compiled C++20 modules are now installed to lib.

Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you!

@wdconinc wdconinc merged commit ec1edd8 into master Dec 31, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants